Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct packageJsonPath determination in ord.js #108

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix: Correct packageJsonPath determination in ord.js #108

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4a42de
Fix packageName undefined issue in ORD plugin and add GitHub Actions …
nirooxx Jan 7, 2025
db84df0
Add workflow for testing ORD compilation with dynamic test files
nirooxx Jan 8, 2025
410f4ea
Add workflow for testing ORD compilation with dynamic test files
nirooxx Jan 8, 2025
10b9e3f
Add workflow for testing ORD compilation with dynamic test files
nirooxx Jan 8, 2025
59f197e
Remove test-ord.yml from workflows
nirooxx Jan 8, 2025
5230d47
Simplify modelPath type check and remove redundant logic
nirooxx Jan 9, 2025
37428d9
fix: revert error message for missing package.json to original wording
nirooxx Jan 9, 2025
a3a8ef4
Update jest snapshots and adjust test case for package.json error han…
nirooxx Jan 9, 2025
5a724b8
fix: Use cds.root with process.cwd fallback + Test files rollback
nirooxx Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/ord.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@ const cds = require("@sap/cds");
const defaults = require("./defaults");
const path = require("path");

const initializeAppConfig = (csn) => {
let packageJsonPath = path.join(cds.root, 'package.json')
const initializeAppConfig = (csn, modelPath = cds.root || process.cwd()) => {

if (typeof modelPath !== 'string') {
throw new TypeError(`Expected "modelPath" to be a string, but received ${typeof modelPath}: ${JSON.stringify(modelPath)}`);
}
nirooxx marked this conversation as resolved.
Show resolved Hide resolved

let packageJsonPath = path.join(modelPath, 'package.json')
let packageJson;
if (cds.utils.exists(packageJsonPath)) {
packageJson = require(packageJsonPath);
Expand Down
Loading