fix: provide tracerProvider and meterProvider explicitly (#215)

closes #216

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## Version 1.0.1 - 2024-08-10
+
+### Fixed
+
+- Explicitly pass own providers when registering instrumentations (the global providers may be influenced by, for example, Dynatrace OneAgent)
+
 ## Version 1.0.0 - 2024-08-08
 
 ### Added

lib/index.js

@@ -33,15 +33,20 @@ module.exports = function () {
   /*
    * setup tracing
    */
-  tracing(resource)
+  const tracerProvider = tracing(resource)
 
   /*
    * setup metrics
    */
-  metrics(resource)
+  const meterProvider = metrics(resource)
 
   /*
    * register instrumentations
    */
-  registerInstrumentations({ instrumentations: _getInstrumentations() })
+  registerInstrumentations({
+    tracerProvider,
+    meterProvider,
+    // loggerProvider,
+    instrumentations: _getInstrumentations()
+  })
 }

lib/metrics/index.js

@@ -102,4 +102,6 @@ module.exports = resource => {
    */
   require('./db-pool')()
   require('./host')()
+
+  return meterProvider
 }

lib/tracing/index.js

@@ -148,10 +148,12 @@ module.exports = resource => {
   })
 
   /*
-   * add CAP instrumentations
+   * add tracing
    */
   require('./cds')()
   // REVISIT: we should be able to remove okra instrumentation entirely, but keep behind feature flag for now
   if (process.env.TRACE_OKRA) require('./okra')()
   require('./cloud_sdk')()
+
+  return tracerProvider
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cap-js/telemetry",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "CDS plugin providing observability features, incl. automatic OpenTelemetry instrumentation.",
   "repository": "cap-js/telemetry",
   "author": "SAP SE (https://www.sap.com)",
@@ -18,6 +18,7 @@
   "dependencies": {
     "@opentelemetry/api": "^1.9",
     "@opentelemetry/core": "^1.25",
+    "@opentelemetry/instrumentation": "^0.52",
     "@opentelemetry/instrumentation-http": "^0.52",
     "@opentelemetry/resources": "^1.25",
     "@opentelemetry/sdk-metrics": "^1.25",
@@ -38,7 +39,6 @@
     "@opentelemetry/exporter-trace-otlp-grpc": "^0.52.1",
     "@opentelemetry/exporter-trace-otlp-proto": "^0.52.1",
     "@opentelemetry/host-metrics": "^0.35.0",
-    "@opentelemetry/instrumentation": "^0.52.1",
     "@opentelemetry/instrumentation-runtime-node": "^0.6.0",
     "@sap/cds-mtxs": "^2.0.5",
     "axios": "^1.6.7",