Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #1221

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2023

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 15, 2023
@ch1bo ch1bo force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from bc29b45 to f530e1e Compare December 19, 2023 10:43
@ch1bo ch1bo requested a review from v0d1ch December 19, 2023 10:44
@locallycompact locallycompact force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch 4 times, most recently from 4537bd0 to 0ba2050 Compare December 19, 2023 17:13
Copy link

github-actions bot commented Dec 19, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-12-19 23:57:37.02181877 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 985245919fcc6c0c5cd116023cd2c947c43e80dcbb5075fe12433fbb 4072
νCommit 7cb20fa71eb4c563ca283566ebe0aa65859d96c3f8cba35c52c181fd 2043
νHead 7a36661f5c15e9f1783aeaab890812c59b7286cbbc6de762d3110772 8816
μHead 8b111ac12274e46314769295a1c5dcab1d260096fc469fd698065463* 3851
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4374 10.46 4.04 0.46
2 4580 12.70 4.89 0.49
3 4774 14.87 5.71 0.52
5 5180 19.12 7.31 0.59
10 6184 30.30 11.55 0.75
41 12417 99.00 37.59 1.77

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 534 11.37 4.44 0.30
2 724 15.04 6.07 0.35
3 909 18.85 7.75 0.40
5 1287 26.90 11.27 0.51
10 2221 49.55 20.97 0.80
19 3911 99.43 41.75 1.43

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 480 21.82 8.53 0.41
2 113 590 34.11 13.43 0.55
3 171 704 44.93 17.92 0.67
4 227 814 61.59 24.64 0.86
5 282 920 74.37 30.07 1.01
6 339 1031 93.56 37.95 1.23

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 560 16.68 7.69 0.37
2 713 18.45 9.30 0.40
3 695 18.21 8.11 0.39
5 1183 22.90 13.52 0.48
10 2148 32.30 22.04 0.66
50 8847 97.86 83.54 1.93

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 582 20.18 8.95 0.40
2 750 22.21 10.65 0.44
3 982 24.28 12.44 0.48
5 1295 28.24 15.81 0.55
10 2277 38.07 24.37 0.73
44 7996 99.65 78.09 1.87

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4326 18.85 8.12 0.55
2 4492 32.10 13.98 0.71
3 4636 47.52 20.85 0.89
4 4667 53.55 23.16 0.96
5 4958 81.01 35.52 1.28

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4206 8.05 3.37 0.42
5 1 57 4239 8.86 3.96 0.44
5 5 285 4375 14.19 7.18 0.51
5 10 568 4544 20.43 11.03 0.59
5 20 1137 4882 32.72 18.65 0.76
5 30 1707 5225 45.15 26.34 0.93
5 40 2278 5566 57.46 33.97 1.10
5 50 2846 5903 69.77 41.61 1.27
5 74 4214 6719 99.34 59.96 1.68

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2023-12-19 23:59:48.935413888 UTC

Baseline Scenario

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 24.495212639
P99 120.00535947000004ms
P95 33.73134039999995ms
P50 20.6957765ms
Number of Invalid txs 0

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 4.176926631
P99 6.465896079999998ms
P95 5.028091450000001ms
P50 4.0631695ms
Number of Invalid txs 0

Copy link

github-actions bot commented Dec 19, 2023

Test Results

379 tests   374 ✔️  21m 47s ⏱️
129 suites      5 💤
    5 files        0

Results for commit 2a33dd0.

♻️ This comment has been updated with latest results.

@locallycompact locallycompact force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 0ba2050 to 6455355 Compare December 19, 2023 17:51
@ch1bo ch1bo force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 6455355 to 46df7e7 Compare December 19, 2023 17:57
@locallycompact locallycompact force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 46df7e7 to 2179b56 Compare December 19, 2023 18:22
Copy link
Collaborator

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes of this PR are fine.

However, we should check whether this third-party action used in the final website building workflow:

  • was updated as well
  • is still compatible with the upstream changes to github artifacts

dependabot bot and others added 2 commits December 20, 2023 00:55
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@ffakenz ffakenz force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 2179b56 to 2a33dd0 Compare December 19, 2023 23:55
@ffakenz
Copy link
Contributor

ffakenz commented Dec 20, 2023

There is an open PR to upgrade this action on the third-party side.

@locallycompact locallycompact merged commit cfac902 into master Dec 20, 2023
21 checks passed
@locallycompact locallycompact deleted the dependabot/github_actions/actions/upload-artifact-4 branch December 20, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants