Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map and debug PlutusFailure cases of ApplyTx #1789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ch1bo
Copy link
Collaborator

@ch1bo ch1bo commented Jan 16, 2025

When submitting transactions which spend from scripts to the L2 cardano ledger, we can use debugPlutus to re-evaluate the script and dump debug information.

This does not fix the formatting though (newlines in Text).

TODO: a test would be good. @noonio you had a e2e scenario where we spend a script on the L2 recently?

This commit is also back-ported onto doom to benefit the hydra-doom project.


  • CHANGELOG updated
  • Documentation updated or not needed
  • Haddocks update not needed
  • No new TODOs introduced

When submitting transactions which spend from scripts to the L2 cardano
ledger, we can use debugPlutus to re-evaluate the script and dump debug
information.

This does not fix the formatting though (newlines in Text).
@ch1bo ch1bo requested review from Quantumplation and a team January 16, 2025 21:12
Copy link
Contributor

@noonio noonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ch1bo
Copy link
Collaborator Author

ch1bo commented Jan 17, 2025

Looks great!

@noonio think we should merge without a test case? Was manually confirmed working by hydra doom people, but without a test it's (too) easy to remove when ledger types will change and annoy (definitely going to happen).

@noonio
Copy link
Contributor

noonio commented Jan 17, 2025

Looks great!

@noonio think we should merge without a test case? Was manually confirmed working by hydra doom people, but without a test it's (too) easy to remove when ledger types will change and annoy (definitely going to happen).

We can't merge the test-case I have; but I'm happy to rebase and see how it plays out with that one once it's in.

I'm happy to merge as-is; (when it compiles 😅).

If you have in mind a much simpler test-case than an end-to-end one I'm very open to that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants