Update smi_stream_dev.c #176
Conversation
This fixes building on DragonOS_Pi64 - not sure if it breaks other OSes or not, though. /home/ubuntu/cariboulite/driver/build/smi_stream_dev.c:1319:28: error: too many arguments to function ‘class_create’ 1319 | smi_stream_class = class_create(THIS_MODULE, DEVICE_NAME);
|
To confirm, this resolved the issue building CaribouLite on the latest DragonOS Pi64 (22.04 Ubuntu) after it switched to the 6.5 kernel for Pi5 support. I haven’t tested running the hat on a pi5 but it did run fine on the Pi4. I’ll add to DragonOS when I get a chance.. |
|
i had run through this on my pi4, then i swapped the hat and sd card to the pi5 and it all worked just the same. |
|
hm but now im having an issue doing it from scratch on the pi 5, i can't get /dev/gpiomem to exist, there are only 0-4 variants, unlike my pi 4. will investigate/compare things later to see what's going on. |
|
That’s strange so doing it from scratch on Pi4 is okay, transferring sd to pi5 is okay, but then you can’t do it from scratch? I swear in my case I did it from scratch on Pi5 but moved sd to the 4. I’ll do it all again asap. |
|
@alphafox02 so it looks like the gpiomem interface was changed and this will require a change above my head here to get it working. i found someone saying that the 40-pin header was part of /dev/gpiomem4, but creating a symlink from gpiomem to gpiomem4 and running SoapySDRUtil caused the system to freeze up instantly. that's the only quick guess i had on this. pi 5 support may not be here yet, but at least you can build with the new kernel on a pi 4. |
| @@ -1316,7 +1316,7 @@ static int smi_stream_dev_probe(struct platform_device *pdev) | |||
| } | |||
|
|
|||
| // Create sysfs entries with "smi-stream-dev" | |||
| smi_stream_class = class_create(THIS_MODULE, DEVICE_NAME); | |||
| smi_stream_class = class_create(DEVICE_NAME); | |||
There was a problem hiding this comment.
doesn't compile. macro class_create requires two parameters
./cariboulite/driver/build/smi_stream_dev.c:1319:45: error: macro "class_create" requires 2 arguments, but only 1 given
1319 | smi_stream_class = class_create(DEVICE_NAME);
| ^
In file included from ./include/linux/platform_device.h:13,
./cariboulite/driver/build/smi_stream_dev.c:44:
./include/linux/device.h:778: note: macro "class_create" defined here
778 | #define class_create(owner, name) \
|
./cariboulite/driver/build/smi_stream_dev.c:1319:21: error: ‘class_create’ undeclared (first use in this function); did you mean ‘vfs_create’?
1319 | smi_stream_class = class_create(DEVICE_NAME);
|
Did you check out the patch-1 branch? |
|
all i know is it doesn't compile for me on ubuntu/dragonos unless i edit the file and remove "THIS_MODULE, ". Not sure if you're using latest 6.5 kernel yet or what you're working on there, but my experience is the opposite of yours... |
|
I can confirm that I was able to build with this mod on a Pi 5 with Ubuntu/DragonOS but get the same GPIOMEM error. Would not compile without. |
|
On a Pi 4 with the latest Bookworm (Pi OS 12): When compiling the driver I get an error relating to the same function in this PR: Applying the patch with So I applied the change manually, and here is my diff: pi@pi4-sdr:~/Downloads/cariboulite $ git diff driver/smi_stream_dev.c
diff --git a/driver/smi_stream_dev.c b/driver/smi_stream_dev.c
index e0d6618..c7f3fba 100644
--- a/driver/smi_stream_dev.c
+++ b/driver/smi_stream_dev.c
@@ -1050,7 +1050,7 @@ static int smi_stream_dev_probe(struct platform_device *pdev)
}
// Create sysfs entries with "smi-stream-dev"
- smi_stream_class = class_create(THIS_MODULE, DEVICE_NAME);
+ smi_stream_class = class_create(DEVICE_NAME);
ptr_err = smi_stream_class;
if (IS_ERR(ptr_err))
{After re-running After a reboot, I launched SoapySDRServer ( |
|
See also: myriadrf/xtrx_linux_pcie_drv@d218d3e After installing CaribouLite's drivers, I'm getting an error for |
|
Jeff with some additional steps you should not have to use sudo to launch Soapy. When I get back to s computer I’ll review but check up under the ticket for how to get going with caribou and DragonOS Pi64. |
|
@alphafox02 - I wanted to be able to get everything running on a bare Pi OS install—my idea is to have a very lightweight/simple setup where it's running Pi OS Lite, with CaribouLite served over SoapySDR, at least for now. DragonOS is a fairly heavyweight OS image that requires additional trust / lifecycle management, which is fine for many purposes/uses of course! Regarding not using sudo... if I want to have the service run on system boot ( |
|
oh yeah, I’m in agreement with you. I was just saying that you could cherry pick some of the additional steps that I detailed in there that may or may not be of help to you. But yeah, starting the service on boot you need Sudo or potentially the user. |
This fixes building on DragonOS_Pi64 - not sure if it breaks other OSes or not, though.
/home/ubuntu/cariboulite/driver/build/smi_stream_dev.c:1319:28: error: too many arguments to function ‘class_create’
1319 | smi_stream_class = class_create(THIS_MODULE, DEVICE_NAME);