Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Carpentries Gitpod environment #159

Merged
merged 10 commits into from
Aug 26, 2024

Conversation

mahesh-panchal
Copy link
Collaborator

@mahesh-panchal mahesh-panchal commented Aug 21, 2024

Updates the Gitpod environment for Carpentries training.

TODO

  • Install tools for exercises. Which tools need to be installed?
  • Which pages should include a Launch in Gitpod button?
  • Where is the description on how to use Gitpod?
  • Are any additional extensions needed?
  • What should the checkout location be?
  • What branch should be checked out?

@mahesh-panchal mahesh-panchal self-assigned this Aug 21, 2024
@mahesh-panchal mahesh-panchal requested a review from ggrimes August 21, 2024 13:37
Copy link

github-actions bot commented Aug 21, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/workflows-nextflow/compare/md-outputs..md-outputs-PR-159

The following changes were observed in the rendered markdown documents:

 md5sum.txt |  2 +-
 setup.md   | 54 +++++++++++++++++++++++++++++++++++++++---------------
 2 files changed, 40 insertions(+), 16 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-26 11:09:57 +0000

github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
@ggrimes
Copy link
Collaborator

ggrimes commented Aug 21, 2024

Install tools for exercises. Which tools need to be installed?

The tools in the environment.yml file

https://github.com/carpentries-incubator/workflows-nextflow/blob/main/episodes/data/environment.yml

@mahesh-panchal
Copy link
Collaborator Author

Do you want those pinned versions for a reason or do you just want the tools installed? For example, Nextflow is pinned, but presumably you want the latest version right?

@ggrimes
Copy link
Collaborator

ggrimes commented Aug 22, 2024

You are right , for nextflow, python and nf-core tools non-pinned and for the specific version of the software below.

  • salmon=1.5
  • fastqc=0.11
  • multiqc=1.10

Install salmon 1.5 fastqc 0.11 multiqc 1.10
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
@mahesh-panchal
Copy link
Collaborator Author

Those three tools have been added to the environment.

Do we have a specific branch that should be checked out and where should we include launch buttons?

@ggrimes
Copy link
Collaborator

ggrimes commented Aug 22, 2024

I don't have a specific branch in mind, the site is rendered from the main branch, if there any reason not to use this?

@mahesh-panchal
Copy link
Collaborator Author

The summary and setup describes an nf-training folder, so ideally a user should land directly in this. Gitpod only clones a repository, and it's up to us to define that the folder has the expected layout one makes in a non-Gitpod environment.

@ggrimes
Copy link
Collaborator

ggrimes commented Aug 23, 2024

Is it possible as part of gitpod environment set up to create this directory and move into it or is this not advised?

tasks:
  - init: |
      mkdir -p nf-training  # Create the directory
      cd nf-training        # Change into the directory

@mahesh-panchal
Copy link
Collaborator Author

Yes, it's possible.
My preference though would be to create a clean environment free from distracting files.
But let's start with that. Better something than nothing.

github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
.gitpod.yml Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@mahesh-panchal
Copy link
Collaborator Author

mahesh-panchal commented Aug 26, 2024

Are there any particular extensions required for vscode that you would like?
Live-server is there so users can view the multiqc reports. Directly clicking on a MQC report from the side will open up the html, but one can right click it and view with the live server instead to view the rendered version.

@ggrimes
Copy link
Collaborator

ggrimes commented Aug 26, 2024

ticular extensions required for vscode that you would like?
Live-server is there so users can view the multiqc reports. Directly clicking on a MQC report from the side will open up the html, but one can right click it and view with the live server instead to view the rendered version.

I don't have any any particular extensions in mind as I am able to view rendered html using the environment you have already setup. Would be great if you could put any useful extensions in. Also how does the live server work can it render and display the course website within the gitpod environment?

@mahesh-panchal
Copy link
Collaborator Author

I've already added a task to open the course website in a panel. There's a gp preview command to do this.

The live server works by right-clicking on a html file and selecting open with live-server.

@mahesh-panchal mahesh-panchal marked this pull request as ready for review August 26, 2024 11:09
@mahesh-panchal mahesh-panchal requested a review from ggrimes August 26, 2024 11:09
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@ggrimes ggrimes merged commit 6ce95f9 into carpentries-incubator:main Aug 26, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
Auto-generated via {sandpaper}
Source  : a87a2ae
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-26 13:50:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
@mahesh-panchal mahesh-panchal deleted the update_gitpod branch August 26, 2024 15:37
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
Auto-generated via {sandpaper}
Source  : a87a2ae
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-26 13:50:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
Auto-generated via {sandpaper}
Source  : a87a2ae
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-26 13:50:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
Auto-generated via {sandpaper}
Source  : a87a2ae
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-26 13:50:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
Auto-generated via {sandpaper}
Source  : a87a2ae
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-26 13:50:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : a87a2ae
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-26 13:50:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6ce95f9
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-08-26 13:49:09 +0000
Message : Merge pull request #159 from mahesh-panchal/update_gitpod

Update Carpentries Gitpod environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants