-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FencDivs need blank line #148
Conversation
adding a blank line and before "at least three colons" because it tripped me, though is located elsewhere in the pandocs guide.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries/sandpaper-docs/compare/md-outputs..md-outputs-PR-148 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-06-30 17:53:44 +0000 |
Funny enough, without the following blank line, it will fail if the the last part of the block is a list: carpentries/sandpaper#355 |
Oh, please ignore my previous comment. That part is covered in https://carpentries.github.io/sandpaper-docs/style.html#whitespace and I realize your comment is addressing the issue of blank lines surrounding the fence, not within the fence. I'll update the style guide to reflect this if it isn't already there. |
Thank you for your contribution, @jas58! |
Auto-generated via {sandpaper} Source : 70325f4 Branch : main Author : Zhian N. Kamvar <[email protected]> Time : 2023-06-30 18:00:15 +0000 Message : Merge pull request #148 from jas58/patch-1 FencDivs need blank line
Auto-generated via {sandpaper} Source : 76085c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-06-30 18:01:42 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 70325f4 Branch : main Author : Zhian N. Kamvar <[email protected]> Time : 2023-06-30 18:00:15 +0000 Message : Merge pull request #148 from jas58/patch-1 FencDivs need blank line
Auto-generated via {sandpaper} Source : 76085c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-06-30 18:01:42 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 70325f4 Branch : main Author : Zhian N. Kamvar <[email protected]> Time : 2023-06-30 18:00:15 +0000 Message : Merge pull request #148 from jas58/patch-1 FencDivs need blank line
adding
a blank line and
before "at least three colons"
because it tripped me, though is located elsewhere in the pandocs guide.
" The fenced Div should be separated by blank lines from preceding and following blocks."
The following blank is best practice, but the preceding break is mandatory (in my experience).