avoid errors when parsing incomplete batches

PanamahSDK.Consts.pas

@@ -3,6 +3,7 @@
 interface
 
 const
+  SDK_VERSION = '1.0.1';
   UTF8_CODEPAGE = 65001;
   LATIN_CODEPAGE = 28591;
   HTTPS_PROTOCOL = 'https';

PanamahSDK.Log.pas

@@ -3,7 +3,7 @@
 interface
 
 uses
-  SysUtils, Classes, SyncObjs, Windows;
+  SysUtils, Classes, SyncObjs, PanamahSDK.Consts, Windows;
 
 type
 
@@ -20,9 +20,11 @@ implementation
 { TPanamahLog }
 
 class procedure TPanamahLogger.Log(const AMessage: string);
+{$IFDEF PANAMAHSDK_LOG}
 var
   LogFilename: string;
   LogFile: TextFile;
+{$ENDIF}
 begin
   {$IFDEF PANAMAHSDK_LOG}
   PanamahLogCriticalSection.Acquire;
@@ -34,7 +36,7 @@ class procedure TPanamahLogger.Log(const AMessage: string);
         Append(LogFile)
       else
         Rewrite(LogFile);
-      WriteLn(LogFile, Format('[%s thread %d] %s', [FormatDateTime('dd/mm/yyyy hh:nn:ss', Now), GetCurrentThreadId, AMessage]));
+      WriteLn(LogFile, Format('[%s thread %d Version ' + SDK_VERSION + '] %s', [FormatDateTime('dd/mm/yyyy hh:nn:ss', Now), GetCurrentThreadId, AMessage]));
     finally
       CloseFile(LogFile);
     end;

PanamahSDK.Operation.pas

@@ -427,11 +427,15 @@ procedure TPanamahOperationList.SetItem(AIndex: Integer;
 end;
 
 procedure TPanamahOperationList.DeserializeFromJSON(const AJSON: string);
+var
+  List: TlkJSONlist;
 begin
-  with TlkJSON.ParseText(AJSON) as TlkJSONlist do
-  begin
-    ForEach(AddJSONObjectToList, nil);
-    Free;
+  List := TlkJSON.ParseText(AJSON) as TlkJSONlist;
+  try
+    if Assigned(List) then
+      List.ForEach(AddJSONObjectToList, nil);
+  finally
+    FreeAndNil(List);
   end;
 end;
 

Tests/JSON/Fixtures/2019_11_08_12_23_17_337.pbt

@@ -0,0 +1 @@
+[{"op":"update","data":{"id":"1","descricao":"DINHEIRO"},"tipo":"FORMA_PAGAMENTO"},{"op":"update","data":{"id":"01234567890123420191101031039784803772470003344","lojaId":"12345678901234","data":"2019-11-01T06:44:00-0300","dataHoraInicio":"2019-11-01T06:44:00-0300","dataHoraFim":"2019-11-01T06:44:00-0300","dataHoraVenda":"2019-11-01T06:44:00-0300","desconto":0,"efetiva":true,"quantidadeItens":1,"quantidadeItensCancelados":0,"sequencial":"397848","servico":0,"tipoPreco":"NORMAL","valor":14.09,"valorItensCancelados":0,"acrescimo":0,"numeroCaixa":"31","itens":[{"acrescimo":0,"desconto":0,"efetivo":true,"funcionarioId":"0003344","preco":

Tests/JSON/PanamahSDKTests.JSON.pas

@@ -0,0 +1,43 @@
+unit PanamahSDKTests.JSON;
+
+interface
+
+uses
+  Math, SysUtils, Classes, TestFramework, IOUtils, PanamahSDK.Batch;
+
+type
+
+  TTestJSONTestCase = class(TTestCase)
+  private
+    function GetFixturePath(const AFilename: string): string;
+  published
+    procedure TestDeserializeCorruptedBatch;
+  end;
+
+implementation
+
+{ TPanamahNFeDeserializerTestCase }
+
+function TTestJSONTestCase.GetFixturePath(
+  const AFilename: string): string;
+begin
+  Result := Concat(GetCurrentDir, '\JSON\Fixtures\', AFilename);
+end;
+
+procedure TTestJSONTestCase.TestDeserializeCorruptedBatch;
+var
+  Batch: TPanamahBatch;
+begin
+  Batch := TPanamahBatch.Create;
+  try
+    Batch.DeserializeFromJSON(TFile.ReadAllText(GetFixturePath('2019_11_08_12_23_17_337.pbt')));
+    Assert(Batch.GetCount = 0);
+  finally
+    Batch.Free;
+  end;
+end;
+
+initialization
+  RegisterTest(TTestJSONTestCase.Suite);
+
+end.