Issue #65: fix: DB error - Linkid variable string numeric value checked #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcghaly
force-pushed
the
MOODLE_39_STABLE-65-biginterr
branch
3 times, most recently
from
3882ea1 to
2d7ad10
Compare
dmitriim
reviewed
Dec 19, 2023
marcghaly
force-pushed
the
MOODLE_39_STABLE-65-biginterr
branch
from
2d7ad10 to
c73e696
Compare
dmitriim
reviewed
Dec 19, 2023
marcghaly
force-pushed
the
MOODLE_39_STABLE-65-biginterr
branch
from
c73e696 to
b1198ef
Compare
dmitriim
reviewed
Dec 19, 2023
| @@ -73,7 +73,7 @@ public static function delete_link_history($linkids) { | |||
| public static function count_clicked_links($userid, $noticeid, $linkid = 0) { | |||
| global $DB; | |||
| $params = []; | |||
| if ($linkid > 0) { | |||
| if ($linkid > 0 && is_numeric($linkid)) { | |||
There was a problem hiding this comment.
how about comparison reported in the issue? Should we also fix its logic?
There was a problem hiding this comment.
Actually I think the right spot for fixing it should be acknowledged_notice::other_cols.
The current method should be fixed if it would have a type hint for $linkid. And it will get one at some point.
|
Would be fixed as part of #81 Closing this one off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #65,
Regards,
Marc-Alexandre