Merge pull request #96 from KepaUrzelai/patch-1

Issue #95: prevent empty referenced course id coding error
catalyst · Sep 19, 2024 · 5852c2b · 5852c2b
2 parents c682037 + ee672f2
commit 5852c2b
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib.php b/lib.php
@@ -427,8 +427,13 @@ function subcourse_update_grades($subcourse, $userid=0, $nullifnone=true) {
     require_once($CFG->dirroot . '/mod/subcourse/locallib.php');
     require_once($CFG->libdir.'/gradelib.php');
 
-    $refgrades = subcourse_fetch_refgrades($subcourse->id, $subcourse->refcourse, false, $userid, false);
-
+    if ($subcourse->refcourse) {
+        $refgrades = subcourse_fetch_refgrades($subcourse->id, $subcourse->refcourse, false, $userid, false);
+    } else {
+        // Prevent empty referenced course id coding error.
+        return GRADE_UPDATE_FAILED;
+    }
+
     if ($refgrades && $refgrades->grades) {
         if (!empty($refgrades->localremotescale)) {
             // Unable to fetch remote grades - local scale is used in the remote course.