Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #97: Fixed the i_add_to_section_and_i_fill_the_form_with Behat deprecation for Moodle 4.4 #98

Open
wants to merge 1 commit into
base: MOODLE_404_STABLE
Choose a base branch
from

Conversation

Julian-Tovar
Copy link

This Pull request fixes the i_add_to_section_and_i_fill_the_form_with Behat deprecation for Moodle 4.4 by using its replacement i_add_to_course_section_and_i_fill_the_form_with.

@danmarsden
Copy link
Member

looks like we've got other behat issues as well - not just the ones you've fixed so far - feel free to leave it here and we'll come back to it one day, but if you get them all passing and send us a pr that would be awesome!

@Julian-Tovar
Copy link
Author

the failures look interesting, I might give them a shot. There are a lot of warnings for php 8.3 (haven't checked 8.1 but I guess it's the same)

@Julian-Tovar
Copy link
Author

okay no the failures are quite involved, my code isn't ready to be merged.

@danmarsden
Copy link
Member

yeah - no surprises tbh - we took over maintenance of the plugin last year and I put a bit of effort into bug squashing and unit test fixing but didn't manage to make it to the behat tests ;-( - it would be really great to get them sorted at some point though - if you don't have much time to dedicate to this feel free to leave this here for now and it might help someone else looking at them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants