Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent buffer overflow #195

Merged
merged 23 commits into from
Dec 8, 2022
Merged

Prevent buffer overflow #195

merged 23 commits into from
Dec 8, 2022

Conversation

CodyCBakerPhD
Copy link
Member

The major fix for this should be taken care of in hdmf-dev/hdmf#780

Replaced #194

@CodyCBakerPhD CodyCBakerPhD self-assigned this Nov 1, 2022
@CodyCBakerPhD CodyCBakerPhD changed the title Prevent buffer overflow 2 Prevent buffer overflow Nov 1, 2022
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Nov 1, 2022
Closed
@CodyCBakerPhD CodyCBakerPhD changed the base branch from main to disable_accepted_rejected_rois November 1, 2022 16:03
@CodyCBakerPhD
Copy link
Member Author

Will probably want to wait until it's merged upstream (and possible requirements conflicts resolved)

Base automatically changed from disable_accepted_rejected_rois to main November 1, 2022 18:48
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review November 11, 2022 16:25
h-mayorquin
h-mayorquin previously approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the cycle of HDMF is too slow to wait for the stable version?

@CodyCBakerPhD
Copy link
Member Author

I guess the cycle of HDMF is too slow to wait for the stable version?

It's something to consider.. If this is merged here we will lock ourselves out of another NeuroConv release until it is, but it's also just a bug fix so maybe we could ask them to do a small release for that

@h-mayorquin
Copy link
Collaborator

h-mayorquin commented Nov 11, 2022 •
edited
Loading

I would like to have a release for neuroconv after the Murthy project. But that probably would be in December if Ben Cowley manages to get the sleap data by then. I have some small fix to add to the sleap interface here but I am waiting for the sleap-io people to do some release with a bug fix that I did over there.

@CodyCBakerPhD CodyCBakerPhD changed the base branch from old_main to main November 25, 2022 05:14
@CodyCBakerPhD CodyCBakerPhD dismissed h-mayorquin’s stale review November 25, 2022 05:14

The base branch was changed.

bendichter
bendichter reviewed Dec 8, 2022
View reviewed changes
requirements-minimal.txt Outdated Show resolved Hide resolved
@CodyCBakerPhD
Copy link
Member Author

CodyCBakerPhD commented Dec 8, 2022 •
edited
Loading

This and #238 are failing due to a new release of packaging yesterday (after our daily scheduled run no less...) introducing a breaking change to version parsing down at the neo level: pypa/packaging#631

I'll try to get a fix here quickly

EDIT: actually might be probeinterface where it stems from...

@CodyCBakerPhD
Copy link
Member Author

OK that fix is going to take a little bit, handed it off to SI team: SpikeInterface/probeinterface#147

and trying to skip the tests here

@bendichter
Copy link
Contributor

Can we just specify an older version for packaging for now and fix it in a separate PR?

@CodyCBakerPhD CodyCBakerPhD merged commit 3a0d416 into main Dec 8, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the prevent_buffer_overflow_2 branch December 8, 2022 17:33
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Dec 12, 2022
Closed
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Mar 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin left review comments

@bendichter bendichter Awaiting requested review from bendichter

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodyCBakerPhD @h-mayorquin @bendichter