Fix region tracker page leak and initial sizing #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When allocating a new region tracker, we need to free the old one. Also, when recreating the region tracker during repair, it has to be large enough for the actual number of regions (which might be more than INITIAL_REGIONS).
|
Nice find, thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When allocating a new region tracker, we need to free the old one. Also, when recreating the region tracker during repair, it has to be large enough for the actual number of regions (which might be more than INITIAL_REGIONS).
I've expanded the existing out_of_regions() test case to exercise both of these code paths; the test will fail without these fixes.