-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHC 9.2 support #12
Conversation
f743840
to
a5fbe5f
Compare
a5fbe5f
to
3d5991a
Compare
@cchalmers How do you feel about removing support for 8.6? I broke something in the upgrade process, and my local installation keeps throwing GHC panics making it hard to debug. I'd rather drop it than putting more energy in.. |
We're still using 8.6 so I'd like to keep supporting that 😅. I'll take a look later and see if I can get it working. |
Oof 😅. There has been some talk about dropping 8.6 support for Clash after releasing 1.8 btw, so hopefully that doesn't mess you guys up too much.
Thanks! I'll see if I can get my local GHC installation to comply too. |
@@ -10,7 +10,6 @@ | |||
For testing the circuit notation. | |||
-} | |||
|
|||
{-# LANGUAGE Arrows #-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the cause of the issue:
{-# LANGUAGE CPP #-}
#if __GLASGOW_HASKELL__ <= 902
{-# LANGUAGE Arrows #-}
#endif
I think fixes it for me. I'll try to test it on our codebase to see if there's any other issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any news on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set off a build and then forgot about it. That one failed because there were other changes since and we weren't up to date. I've set off another build with a fix, hopefully I won't forget about this one.
Merged #15 instead, a rebased version of this. |
TODO: