PR #2198 and PR #2207 Fixed #2219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
=======================================
Coverage 81.50% 81.50%
=======================================
Files 77 77
Lines 9522 9522
Branches 1151 1151
=======================================
Hits 7761 7761
Misses 1569 1569
Partials 192 192 ☔ View full report in Codecov by Sentry. |
|
@auvipy can you review this PR ? |
auvipy
requested changes
Jan 8, 2025
| @@ -82,19 +82,7 @@ jobs: | |||
| 'py-kafka' | |||
| ] | |||
| experimental: [false] | |||
| include: | |||
| - python-version: pypy3.10 | |||
| toxenv: 'py-amqp' | |||
There was a problem hiding this comment.
Why does this part have to be removed? Can you explain please?
There was a problem hiding this comment.
Yes , I think pypy3.10 is required here for make certain workloads faster. I will undo the change .
|
You should check why integration tests are failing on pypy. Do protobuf work with pypy? If not you can skip pypy for grpc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.