Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SettlementRodMeasurement and SettlementRodMeasurementSeries classes #18

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

PabloVasconez
Copy link
Contributor

@PabloVasconez PabloVasconez commented Jun 4, 2024

In addition, classes Project and MeasurementDevice are also created.

Pablo Vasconez added 2 commits June 3, 2024 17:04
@PabloVasconez PabloVasconez linked an issue Jun 4, 2024 that may be closed by this pull request
Pablo Vasconez added 2 commits June 6, 2024 16:53
…nt according to comments from Michel (CRUX) and Daniel (BouwRisk)
…Series class to represent a series of measurements for a single settlement rod and update docs
@PabloVasconez PabloVasconez changed the title 1 create settlementrodmeasurements class Create SettlementRodMeasurement and SettlementRodMeasurementSeries classes Jun 6, 2024
@PabloVasconez PabloVasconez requested a review from RDWimmers June 6, 2024 14:58
@PabloVasconez PabloVasconez self-assigned this Jun 6, 2024
Copy link
Member

@RDWimmers RDWimmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do miss a plot method on the SettlementRodMeasurementSeries class.
Also, some small comments below

@RDWimmers RDWimmers added enhancement New feature or request github_actions Pull requests that update GitHub Actions code python Pull requests that update Python code labels Jun 7, 2024
…teReferenceSystems class and refactor attribute names in SettlementRodMeasurement as discussed in comments of PR #18
@PabloVasconez PabloVasconez requested a review from RDWimmers June 10, 2024 09:51
docs/tree/figures/settlement_rod.png Outdated Show resolved Hide resolved
src/baec/coordinates.py Show resolved Hide resolved
src/baec/coordinates.py Show resolved Hide resolved
@PabloVasconez PabloVasconez merged commit 11184ff into main Jun 10, 2024
16 checks passed
PabloVasconez pushed a commit that referenced this pull request Jun 10, 2024
…teReferenceSystems class and refactor attribute names in SettlementRodMeasurement as discussed in comments of PR #18
@RDWimmers RDWimmers deleted the 1-create-settlementrodmeasurements-class branch June 10, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SettlementRodMeasurements class
2 participants