Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor status and add status messages to SettlementRodMeasurement #29

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

PabloVasconez
Copy link
Contributor

@PabloVasconez PabloVasconez commented Jul 3, 2024

No description provided.

@PabloVasconez PabloVasconez requested a review from RDWimmers July 3, 2024 12:16
@PabloVasconez PabloVasconez self-assigned this Jul 3, 2024
@PabloVasconez PabloVasconez changed the title refactor!(settlement_measurement_rod): refator status and add status … Refactor status and add status messages to SettlementRodMeasurement Jul 3, 2024

# Valid input using start_index = -2.
series.start_index = -2
# Valid input using the following cases for start_index and start_date_time:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use the parametrization of pytest ->
https://docs.pytest.org/en/7.1.x/how-to/parametrize.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct! I will do that :)

Copy link
Member

@RDWimmers RDWimmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR 🚀

@PabloVasconez PabloVasconez force-pushed the add_status_messages branch from 5f8fb22 to d16cc88 Compare July 3, 2024 12:56
@PabloVasconez PabloVasconez merged commit 395f76b into main Jul 3, 2024
15 checks passed
@PabloVasconez PabloVasconez deleted the add_status_messages branch July 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants