-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basetime actions and updates #42
Conversation
…actions # Conflicts: # pyproject.toml # requirements.txt
nice, almost there. lest move all the logic to https://github.com/cemsbv/BAEC/blob/main/src/baec/measurements/io/basetime.py because it replaces the current flow right? and we dont need to copy the class. are we happy with the names?? @PabloVasconez |
do we need to update the https://github.com/cemsbv/BAEC/blob/basetime_actions/example/basetime.py? |
pyproj.CRS.from_user_input(list_epsg_codes[0]), | ||
) | ||
else: | ||
coordinate_reference_systems = CoordinateReferenceSystems(None, None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we place the logic above in convert_epsg_string_to_list_int
, now we have two places where there is a if else structure.
list comprehensions has been added instead of 'for loops'. settlement_cache has been set to a private variable. I unfortunately delete the comment I think while testing the class with super_linter. |
on the aws server for project |
Correct, this projects needs to be adjusting with the new template. Only the measurements of |
Update of the Basetime connection.
This version uses the lambda function to gather data, which are the same lambda function as the Basetime resful API will use.