Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basetime actions and updates #42

Merged
merged 23 commits into from
Oct 10, 2024
Merged

Basetime actions and updates #42

merged 23 commits into from
Oct 10, 2024

Conversation

BasetimeBV
Copy link
Collaborator

Update of the Basetime connection.
This version uses the lambda function to gather data, which are the same lambda function as the Basetime resful API will use.

@RDWimmers RDWimmers self-assigned this Oct 1, 2024
@RDWimmers RDWimmers self-requested a review October 1, 2024 10:35
@RDWimmers RDWimmers assigned BasetimeBV and unassigned RDWimmers Oct 1, 2024
@RDWimmers RDWimmers added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 1, 2024
@RDWimmers
Copy link
Member

nice, almost there. lest move all the logic to https://github.com/cemsbv/BAEC/blob/main/src/baec/measurements/io/basetime.py because it replaces the current flow right? and we dont need to copy the class.

are we happy with the names?? @PabloVasconez

@RDWimmers
Copy link
Member

do we need to update the https://github.com/cemsbv/BAEC/blob/basetime_actions/example/basetime.py?

@RDWimmers RDWimmers linked an issue Oct 1, 2024 that may be closed by this pull request
13 tasks
src/baec/measurements/basetime_measurements.py Outdated Show resolved Hide resolved
pyproj.CRS.from_user_input(list_epsg_codes[0]),
)
else:
coordinate_reference_systems = CoordinateReferenceSystems(None, None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we place the logic above in convert_epsg_string_to_list_int, now we have two places where there is a if else structure.

src/baec/measurements/basetime_measurements.py Outdated Show resolved Hide resolved
@BasetimeBV
Copy link
Collaborator Author

list comprehensions has been added instead of 'for loops'. settlement_cache has been set to a private variable. I unfortunately delete the comment I think while testing the class with super_linter.
The https://github.com/cemsbv/BAEC/blob/main/src/baec/measurements/io/basetime.py is no needed anymore, as the new tests and versions now contain the correct new version.

@RDWimmers
Copy link
Member

on the aws server for project Flevokusthaven the timestamp are different than Voorbelasting Wilderszijde Lansingerland. we expect '%Y-%m-%dT%H:%M:%S', see failed test

@BasetimeBV
Copy link
Collaborator Author

on the aws server for project Flevokusthaven the timestamp are different than Voorbelasting Wilderszijde Lansingerland. we expect '%Y-%m-%dT%H:%M:%S', see failed test

Correct, this projects needs to be adjusting with the new template. Only the measurements of Voorbelasting Wilderszijde Lansingerland are correct at this moment.

@RDWimmers RDWimmers merged commit 6c1580a into main Oct 10, 2024
12 checks passed
@RDWimmers RDWimmers deleted the basetime_actions branch October 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor BaseTimeBucket and add class BaseTimeProjectData
2 participants