Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: link scheduling #75

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: link scheduling #75

wants to merge 10 commits into from
+100 −10

Conversation

AfonsoMartins26
Copy link

No description provided.

@AfonsoMartins26 AfonsoMartins26 linked an issue Sep 18, 2024 that may be closed by this pull request
Link scheduling #73
Open
@AfonsoMartins26 AfonsoMartins26 changed the title Feat: update list_unarchived_links_by_index Link scheduling Sep 18, 2024
@AfonsoMartins26 AfonsoMartins26 marked this pull request as draft September 18, 2024 20:59
@AfonsoMartins26 AfonsoMartins26 changed the title Link scheduling feat: link scheduling Sep 18, 2024
@AfonsoMartins26 AfonsoMartins26 marked this pull request as ready for review September 19, 2024 10:28
MarioRodrigues10
MarioRodrigues10 requested changes Sep 20, 2024
View reviewed changes
lib/cesium_link/links.ex Outdated Show resolved Hide resolved
@AfonsoMartins26 AfonsoMartins26 self-assigned this Sep 22, 2024
joaodiaslobo
joaodiaslobo requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 🤩
Can you add a timer to links that have been scheduled and maybe reduce their opacity while not published?
Something like this:
image

@AfonsoMartins26 AfonsoMartins26 requested review from joaodiaslobo and removed request for JulioJPinto September 23, 2024 17:49
@AfonsoMartins26
Copy link
Author

AfonsoMartins26 commented Sep 27, 2024 •
edited
Loading

Works great! 🤩 Can you add a timer to links that have been scheduled and maybe reduce their opacity while not published? Something like this: image

The opacity is working but it doesn't go away when the link gets to the home page.... 😿

joaodiaslobo
joaodiaslobo requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything backend-wise is great! Good job!
Now, to represent a scheduled link on the backoffice table, we should probably use JavaScript to make it more interactive and up to date. Learn more about Phoenix hooks here

MarioRodrigues10
MarioRodrigues10 requested changes Jan 10, 2025
View reviewed changes
lib/cesium_link_web/live/link_live/index.html.heex
<:col :let={{_id, link}} label="Name">
<p class="font-semibold text-zinc-900"><%= link.name %></p>
<p class={"font-semibold text-zinc-900 #{if publish_in_future?(link), do: "opacity-50"}"}><%= link.name %></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid repeating publish_in_future in every p pre-calculate this before when you fetch and assign links

Suggested change
<p class={"font-semibold text-zinc-900 #{if publish_in_future?(link), do: "opacity-50"}"}><%= link.name %></p>
<p class={"font-semibold text-zinc-900 #{if publish_in_future?(link), do: "opacity-50"}"}><%= link.name %></p>

lib/cesium_link_web/live/link_live/index.html.heex
@@ -15,30 +15,55 @@
</.header>

<.table id="links" rows={@streams.links} phx-hook="Sorting">
<:col :let={{_id, _link}}><.icon name="hero-bars-3 cursor-pointer ml-4" class="handle w-5 h-5" /></:col>
<:col :let={{_id, link}}>
<.icon name="hero-bars-3 cursor-pointer ml-4" class={"handle w-5 h-5 #{if publish_in_future?(link), do: "opacity-50"}"} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
<:col :let={{_id, link}} label="Emoji">
<.emoji code={link.emoji} />
<span class={if publish_in_future?(link), do: "opacity-50"}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
<:col :let={{_id, link}} label="URL">
<.link target="_blank" class="hover:text-brand hover:underline" navigate={link.url}>
<.link target="_blank" class={"hover:text-brand hover:underline #{if publish_in_future?(link), do: "opacity-50"}"} navigate={link.url}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
<:col :let={{_id, link}} label="Clicks"><%= link.visits %></:col>

<:col :let={{_id, link}} label="Time Left">
<%= if publish_in_future?(link) do %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
</:col>

<:col :let={{_id, link}} label="Clicks">
<p class={if publish_in_future?(link), do: "opacity-50"}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
<:col :let={{_id, link}} label="Attention">
<input type="checkbox" disabled={true} checked={link.attention} class="self-center block rounded-md text-gray-600" />
<input type="checkbox" disabled={true} checked={link.attention} class={"self-center block rounded-md text-gray-600 #{if publish_in_future?(link), do: "opacity-50"}"} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
<:action :let={{_id, link}}>
<.link patch={~p"/admin/links/#{link}/edit"}>
<.icon name="hero-pencil" class="w-5 h-5" />
<.icon name="hero-pencil" class={"w-5 h-5 #{if publish_in_future?(link), do: "opacity-50"}"} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/cesium_link_web/live/link_live/index.html.heex
<:action :let={{_id, link}}>
<.link patch={~p"/admin/links/#{link}/archive"}>
<.icon name="hero-archive-box" class="w-5 h-5" />
<.icon name="hero-archive-box" class={"w-5 h-5 #{if publish_in_future?(link), do: "opacity-50"}"} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonmestevao nelsonmestevao nelsonmestevao left review comments

@MarioRodrigues10 MarioRodrigues10 MarioRodrigues10 requested changes

@nunom27 nunom27 Awaiting requested review from nunom27

@FilipeR13 FilipeR13 Awaiting requested review from FilipeR13

@joaodiaslobo joaodiaslobo Awaiting requested review from joaodiaslobo

Requested changes must be addressed to merge this pull request.

Assignees

@AfonsoMartins26 AfonsoMartins26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link scheduling
4 participants
@AfonsoMartins26 @nelsonmestevao @joaodiaslobo @MarioRodrigues10