Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] 2019/9/21 #154

Merged
merged 20 commits into from
Sep 24, 2019
Merged

[Sync] 2019/9/21 #154

merged 20 commits into from
Sep 24, 2019

Conversation

Vadaski
Copy link
Member

@Vadaski Vadaski commented Sep 21, 2019

madmonl and others added 19 commits September 18, 2019 09:12
Update description of the search-all page.
Someone had updated our main search engine to search more than dart.dev. I've changed it back (because getting flutter.dev results when I wanted dart.dev was really annoying) and added more sites to this search.
Resolves the second item of #1803.

* Analysis options page: ensure code excerpts are analyzed/tested

* Replace images of code with tooltip by code excerpts

* Edits inspired by Kathy's comments

* Add IDE-like analyzer-error highlighting to implicit-casts example

* Drop linenums from implicit-casts example
Follow up to #1923
* Examples: pubspec descriptions: dartlang.org -> dart.dev

* Rename pub-dartlang-dart to pub-dev

* Examples: rename dartlang_strong to examples_strong

* Examples: rename dartlang_examples_util to examples_util

* Rename dartlang.org to dart.dev, where appropriate

* README.md: www-dartlang to dart-dev

* Misc anchor markdown renames to drop dartlang

* Misc replacements of dartlang.org by dart.dev

* Replace hardcoded URLs by site.dartpadx

* Replace http(s)//news.dartlang.org by {{site.news}}
Copy link
Member

@chenglu chenglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commit my suggestions please, @Vadaski

src/tools/pub/cmd/pub-global.md Outdated Show resolved Hide resolved
src/tools/pub/cmd/pub-global.md Outdated Show resolved Hide resolved
src/tools/pub/cmd/pub-global.md Outdated Show resolved Hide resolved
Copy link
Member

@chenglu chenglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@chenglu chenglu merged commit 1a53666 into cfug:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants