-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sync] 2019/9/21 #154
Merged
Merged
[Sync] 2019/9/21 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update description of the search-all page.
Someone had updated our main search engine to search more than dart.dev. I've changed it back (because getting flutter.dev results when I wanted dart.dev was really annoying) and added more sites to this search.
Resolves the second item of #1803. * Analysis options page: ensure code excerpts are analyzed/tested * Replace images of code with tooltip by code excerpts * Edits inspired by Kathy's comments * Add IDE-like analyzer-error highlighting to implicit-casts example * Drop linenums from implicit-casts example
Follow up to #1923
* Examples: pubspec descriptions: dartlang.org -> dart.dev * Rename pub-dartlang-dart to pub-dev * Examples: rename dartlang_strong to examples_strong * Examples: rename dartlang_examples_util to examples_util * Rename dartlang.org to dart.dev, where appropriate * README.md: www-dartlang to dart-dev * Misc anchor markdown renames to drop dartlang * Misc replacements of dartlang.org by dart.dev * Replace hardcoded URLs by site.dartpadx * Replace http(s)//news.dartlang.org by {{site.news}}
Fixes #1937
Closes #1028
chenglu
reviewed
Sep 24, 2019
chenglu
requested changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commit my suggestions please, @Vadaski
chenglu
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123