-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sync] 2019/10/31 #161
Merged
Merged
[sync] 2019/10/31 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken link to mockito tests
(We can't run the analyzer over multiple projects in one go.)
Contributes to #1972
- Contributes to #1929 - Introduces a temporary fix as requested by @chalin.
* Rename results files so that they are stable vs dev based * Updated dev channel analyzer results * Add comment to stable results concerning analyzer bug * Update examples/README.md * Support channel-based analyzer-result naming * Rename results files in code-excerpt instructions * Ignore token cleanup for misc/lib/core/hash_code.dart * Eliminate 1-only ignore directives * Replace all "1, 2" ignore tokens by "stable, dev" * Replace all "2" ignore tokens by "stable, dev" * Fix line numbers for analyzer-results-dev following code changes * Remove support for "1" and "2" ignore tokens
* Fix invalid anchor in publishing page - Fix typo in anchor name: `#uploader` -> `#uploaders` - Markdown cleanup: use triple-tick for code blocks * Fix pub.dev link * Use console-output style for pub command output
* CI: deploy site only once per build * Feedback from John * Deploy only for push type builds, not PR or cron builds
Change "are free implement" to "are free to implement."
This completes the TODO item in main.scss: reclaim and use the class names good and bad (rather than good-style and bad-style). Cleanup following #2037
- Closes #1758. As of this PR we no longer directly list `sass` as a dependency, but it still is a transitive dependency. We'll need to upgrade to Jekyll 4 (#2043) and the latest jekyll-assets to get rid of that. - Closes #2040
仍有 code-check 的问题,需要再抽时间解决一下。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #123