Update healthcheck.sh #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed retry logic from function: check_cncli_send_tip()
|
@TrevorBenson - Quick @ mention to bring it this to your attention... not sure if this might have slipped through the net as you haven't responded and it relates to PR: cardano-community#1842 |
Yep, suggestions are nice for small bits, but unchanged lines can be a pain. THanks for the PR, I'll start a review today so it can be merged in. Thanks! |
- Increased accuracy of "Pooltool" log scrape pattern. - Included ($pt_log_entry) in output for improved logging/debugging. - Improved variable names for clarification.
TrevorBenson
approved these changes
Jan 21, 2025
TrevorBenson
merged commit 36d6525
into
chaincrucial:sidecar-healthchecks
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed retry logic from function: check_cncli_send_tip()
(Using a PR rather than suggestion as I wasn't able to make a code suggestion over the deleted lines in the compare view)