Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin torchdata + fix some typing errors #1325

Merged
merged 11 commits into from
Jan 9, 2025
Merged

Conversation

ivirshup
Copy link
Collaborator

@ivirshup ivirshup commented Jan 7, 2025

This has ended up being a bit of a grab bag targeting some CI issues that have come up over the past couple weeks.

  • Pin torchdata to a version that has datapipes
  • Fix a number of mypy issues, mostly having to do with numpy typing thinking that operations might change the floating point type. A few of these are around us changing re-assigning a variable with a reshaped version.
  • Fix a test that was prematurely closing a tiledbsoma object, which was then re-used in later tests. This probably should have been failing before, so something must have been fixed in tiledbsoma.

@ivirshup ivirshup changed the title Pin torchdata Pin torchdata + fix some typing errors Jan 7, 2025
@ivirshup ivirshup requested a review from ebezzi January 7, 2025 22:55
@ivirshup ivirshup added the dependencies Pull requests that update a dependency file label Jan 7, 2025
@ivirshup ivirshup marked this pull request as ready for review January 7, 2025 22:59
@ivirshup
Copy link
Collaborator Author

ivirshup commented Jan 8, 2025

Hmm. Seems like I may have triggered some segfaults. I will try splitting this out a bit.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (f32c274) to head (db43e76).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...us/src/cellxgene_census/experimental/pp/_online.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   91.36%   91.35%   -0.01%     
==========================================
  Files          82       82              
  Lines        6482     6480       -2     
==========================================
- Hits         5922     5920       -2     
  Misses        560      560              
Flag Coverage Δ
unittests 91.35% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivirshup ivirshup merged commit aa51fcb into main Jan 9, 2025
15 checks passed
@ivirshup ivirshup deleted the ivirshup/pin-torchdata branch January 9, 2025 17:02
@ivirshup ivirshup mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants