Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LTS compat tests #1326

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix LTS compat tests #1326

merged 2 commits into from
Jan 10, 2025

Conversation

ivirshup
Copy link
Collaborator

@ivirshup ivirshup commented Jan 7, 2025

LTS compatibility tests have been failing for the past four months. I believe this is mostly due to uninstallable dependencies for old very old versions of the package.

Checking here: https://github.com/chanzuckerberg/cellxgene-census/actions/runs/12661005585

Run with:

gh workflow run lts-compat-check.yml --ref ivirshup/fix-lts-compat-tests

@ivirshup ivirshup added the dependencies Pull requests that update a dependency file label Jan 7, 2025
@ivirshup ivirshup marked this pull request as ready for review January 9, 2025 17:03
@ivirshup ivirshup requested a review from ebezzi January 9, 2025 17:16
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (aa51fcb) to head (d5e69be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files          82       82           
  Lines        6480     6480           
=======================================
  Hits         5920     5920           
  Misses        560      560           
Flag Coverage Δ
unittests 91.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivirshup ivirshup merged commit 7f617e3 into main Jan 10, 2025
15 checks passed
@ivirshup ivirshup deleted the ivirshup/fix-lts-compat-tests branch January 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants