Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined error when running rails g impressionist(undefined method `timestamped_migrations') #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed undefined error when running rails g impressionist(undefined method `timestamped_migrations') #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/generators/active_record/impressionist_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class ImpressionistGenerator < Rails::Generators::Base
# FIX, why is this implementing rails behaviour?
def self.next_migration_number(dirname)
sleep 1
if ActiveRecord::Base.timestamped_migrations
if timestamped_migrations?
Time.now.utc.strftime("%Y%m%d%H%M%S")
else
"%.3d" % (current_migration_number(dirname) + 1)
Expand All @@ -17,6 +17,18 @@ def self.next_migration_number(dirname)
def create_migration_file
migration_template 'create_impressions_table.rb.erb', 'db/migrate/create_impressions_table.rb'
end

class << self
private

def timestamped_migrations?
if Rails::VERSION::MAJOR >= 7
ActiveRecord.timestamped_migrations
else
ActiveRecord::Base.timestamped_migrations
end
end
end
end
end
end