Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes for deployment with docker compose #498

Merged

Conversation

Pascal-Delange
Copy link
Contributor

@Pascal-Delange Pascal-Delange commented Mar 6, 2024

  • new env variable "enable_gc_tracing" (requires application default credentials to run)
  • use alpine instead of distroless image to have access to wget to use in docker-compose health checks
  • better documentation of what env variables do
  • drop "VerifySessionCookie" logic in auth middleware, that was no longer supposed to be used but messed up all our error logging related to token validation

@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-495-implement-gcp-deployable-dockerinfra branch from 82cada2 to 683af00 Compare March 8, 2024 10:27
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-495-implement-gcp-deployable-dockerinfra branch from 683af00 to 423186f Compare March 8, 2024 10:29
@Pascal-Delange Pascal-Delange marked this pull request as ready for review March 8, 2024 11:32
@Pascal-Delange Pascal-Delange requested a review from balzdur March 8, 2024 11:32
Dockerfile Show resolved Hide resolved
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-495-implement-gcp-deployable-dockerinfra branch from e769a9e to c1cbe1d Compare March 8, 2024 15:19
@Pascal-Delange Pascal-Delange merged commit 755623d into main Mar 8, 2024
3 checks passed
@Pascal-Delange Pascal-Delange deleted the pascal/mar-495-implement-gcp-deployable-dockerinfra branch March 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants