AST: Lazy evaluate boolean child nodes. #799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apognu
commented
Jan 14, 2025
|
Will amend tomorrow morning with the discussed edits. |
This adds circuit breaking to boolean evaluation. An AND boolean resolves to false if the first operand is false, and an OR boolean resolves to true if the first operand is true. With this, second operands and skipped if they can have no sway on the node's result.
apognu
force-pushed
the
feat/ast-boolean-lazy-evaluation
branch
from
896f4f0 to
d0d3c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds circuit breaking to boolean evaluation.
An AND boolean resolves to false if the first operand is false, and an OR boolean resolves to true if the first operand is true. With this, second operands and skipped if they can have no sway on the node's result.
Circuit breaking is disabled when trying to validate a scenario, so all cases are considered.