Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shahid/cs pg password remove #8718

Closed
wants to merge 3 commits into from
Closed

Conversation

jashaik
Copy link
Contributor

@jashaik jashaik commented Dec 26, 2024

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

SanjuPal01 and others added 3 commits December 12, 2024 09:20
* Storing password in secret helper

Signed-off-by: “SanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: “SanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: “SanjuPal01” <[email protected]>

---------

Signed-off-by: “SanjuPal01” <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit ad3c168
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/676d12c36da2da000959881d
😎 Deploy Preview https://deploy-preview-8718--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Quality Gate failed Quality Gate failed

Failed conditions
3 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@jashaik jashaik closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants