-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHEF-10965] Fixing bundler config syntax change in bundler > v2.1 #8733
Open
RoyShravani
wants to merge
12
commits into
main
Choose a base branch
from
roy/CHEF-10965
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
RoyShravani
changed the title
[CHEF-10965] Test Build
[CHEF-10965] Fixing bundler config syntax change in bundler > v2.1
Jan 15, 2025
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
RoyShravani
force-pushed
the
roy/CHEF-10965
branch
from
January 15, 2025 14:09
b386488
to
82ddd14
Compare
saghoshprogress
approved these changes
Jan 16, 2025
Signed-off-by: RoyShravani <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Fixing bundler config syntax change in bundler > v2.1
Ruby 3.0.1 came with Bundler 2.1.x (likely Bundler 2.1.4 or similar) where Bundler introduced several new features and improvements, one of which was syntactical change in the bundle config command.
With upgrade to Ruby 3.0.1 in Infra-server (ocid) 15.8.0 bundler doesn’t recognise this older command and ignores the local configuration and creates the ./bundle at the root which is the default bundler behaviour as we need to run automate as a root user.
This creates conflict with global environment variables like GEM_PATH and GEM_HOME.
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable