Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHEF-10965] Fixing bundler config syntax change in bundler > v2.1 #8733

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

RoyShravani
Copy link
Contributor

@RoyShravani RoyShravani commented Jan 9, 2025

🔩 Description: What code changed, and why?

Fixing bundler config syntax change in bundler > v2.1

Ruby 3.0.1 came with Bundler 2.1.x (likely Bundler 2.1.4 or similar) where Bundler introduced several new features and improvements, one of which was syntactical change in the bundle config command.
With upgrade to Ruby 3.0.1 in Infra-server (ocid) 15.8.0 bundler doesn’t recognise this older command and ignores the local configuration and creates the ./bundle at the root which is the default bundler behaviour as we need to run automate as a root user.
This creates conflict with global environment variables like GEM_PATH and GEM_HOME.

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Copy link

netlify bot commented Jan 9, 2025

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit c06bd23
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/678915a9e42b7500086a616d

@RoyShravani RoyShravani self-assigned this Jan 9, 2025
@RoyShravani RoyShravani changed the title [CHEF-10965] Test Build [CHEF-10965] Fixing bundler config syntax change in bundler > v2.1 Jan 15, 2025
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants