Fix commented out cops due to renames #981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames per rubocop/rubocop#7468 Signed-off-by: Tim Smith <[email protected]>
See rubocop/rubocop#7813 Signed-off-by: Tim Smith <[email protected]>
These were renamed in rubocop/rubocop#7460 Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Renamed in rubocop/rubocop#4864 Signed-off-by: Tim Smith <[email protected]>
Renamed in rubocop/rubocop#3226 Signed-off-by: Tim Smith <[email protected]>
These were renamed in rubocop/rubocop#6983 Signed-off-by: Tim Smith <[email protected]>
Renamed in rubocop/rubocop#3797 Signed-off-by: Tim Smith <[email protected]>
This one was partially updated at some point, but is not right: See https://github.com/rubocop/rubocop/blob/e12b51389500da8e744730f8fa022d739ba0b573/config/obsoletion.yml#L45 Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
johnmccrae
approved these changes
Dec 9, 2024
sean-simmons-progress
added
the
Triage: Needs Information
|
Quick $0.02 for Progress reviewers - a potential sticking point is specifically the cookstyle.yml changes, which as Tim pointed out will fire on downstream CI changes. Some discussion @tpowell-progress and I had (and discussed in the CAC around the time of moving Chefstyle into Cookstyle) was 'streams' (#967) to avoid that issue, but I haven't had time to get that sorted out yet. I'm personally fine with more lints enabled, but I'm not a typical customer, either ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the cops broken during one of my upgrades a long time ago. This is probably going to result in CI failures elsewhere as these cops have been disabled for a while. Test Kitchen triggered on one of the alignment cops.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.