Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: Fix issues with newer versions of lscpu #1809

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

ramereth
Copy link
Contributor

Starting in util-linux v2.36, the output of lscpu changed which introduced some
bugs in some platforms. To work around this, the previous output can be retained
if the lscpu command is piped to something else. To work around that, this just
pipes the output to cat.

This fixes #1805

Signed-off-by: Lance Albertson [email protected]

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramereth ramereth force-pushed the lscpu-util-linux-fixes branch from e79c266 to b1d57ed Compare August 2, 2024 15:16
@ramereth ramereth marked this pull request as ready for review August 2, 2024 15:16
@ramereth ramereth requested review from a team as code owners August 2, 2024 15:16
Starting in util-linux v2.36, the output of lscpu changed which introduced some
bugs in some platforms. To work around this, the previous output can be retained
if the lscpu command is piped to something else. To work around that, this just
pipes the output to cat.

This fixes chef#1805

Signed-off-by: Lance Albertson <[email protected]>
@ramereth ramereth force-pushed the lscpu-util-linux-fixes branch from b1d57ed to aa23736 Compare August 2, 2024 15:45
Copy link

sonarqubecloud bot commented Aug 2, 2024

@tpowell-progress tpowell-progress self-assigned this Aug 6, 2024
@tpowell-progress tpowell-progress merged commit ff52965 into chef:main Aug 6, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lscpu on Debian VM on ARM system crashes CPU plugin
3 participants