Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry names config. #136

Merged
merged 9 commits into from
Mar 29, 2023
Merged

Fix entry names config. #136

merged 9 commits into from
Mar 29, 2023

Conversation

edoardocavazza
Copy link
Member

Should fix #128 and #135

@edoardocavazza edoardocavazza added the bug Something isn't working label Mar 28, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: 7074235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chialab/esbuild-rna Patch
@chialab/rna-config-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (09e9244) 89.00% compared to head (7074235) 89.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   89.00%   89.01%           
=======================================
  Files          40       40           
  Lines        6394     6398    +4     
=======================================
+ Hits         5691     5695    +4     
  Misses        703      703           
Impacted Files Coverage Δ
packages/esbuild-plugin-meta-url/lib/index.js 88.73% <100.00%> (ø)
packages/esbuild-plugin-worker/lib/index.js 81.91% <100.00%> (ø)
packages/esbuild-rna/lib/Build.js 91.95% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edoardocavazza edoardocavazza merged commit d67113e into main Mar 29, 2023
@edoardocavazza edoardocavazza deleted the fix-entry-names branch March 29, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esbuild-plugin-html does not use the original directory of the source file
1 participant