-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ia tickets 26 71 user dashboard #94
Feature/ia tickets 26 71 user dashboard #94
Conversation
…hub.com/chingu-voyages/v40-geckos-team-18 into feature/ia-tickets-26-71-user-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing Ivan! The only issues I'm having is for mobile responsiveness. I don't know if you want to make a separate cleanup ticket for that or if you think they're easy fixes but here's what I've found:
Cards overlap on Tablet size screens (768px
)
On mobile screens (320px
) the cards are overflowing and getting cut off I think the padding for the cards needs to be smaller when on mobile
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those responsiveness issues! Looks good now, approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Are we production ready?
And the last big ticket!
Full featured dashboard with individual summary pages:
Dash:
Fuel, Electricity, and Flight summary pages:
Vehicle summary page:
All summary pages:
Let me know if you find problems!
You need to run
npm i
to get the package I used for the circular progress indicators!Closes tickets #26, #71