Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ia tickets 26 71 user dashboard #94

Merged
merged 48 commits into from
Sep 10, 2022

Conversation

ialej001
Copy link
Contributor

@ialej001 ialej001 commented Sep 8, 2022

And the last big ticket!

Full featured dashboard with individual summary pages:

Dash:

  • Total emissions summary based on the user's unit preference
  • Circular progress indicators change color based on its respective percentage
    • 0% should be displayed when there is absolute no calculations saved
    • Otherwise, the percentage should be rendered center of the circle
    • Color changes happen at:
      • [ 0-40 ] %: green
      • ( 40-80 ] %: yellow
      • ( 80-100 ] %: red
  • Each card also changes its emissions value based on the user's unit preference

Fuel, Electricity, and Flight summary pages:

  • Render a responsive table, collapsing columns as the view-port shrinks
  • Each page has a header
  • Each page has a 'empty table' message, linking to the appropriate calculator page to start

Vehicle summary page:

  • On larger screens, a tabbed UI is rendered. Each tab corresponds to a user's vehicle
  • On smaller screens, an accordion UI is rendered
  • In either style:
    • A table is rendered, responsive to the size of the view-port, collapsing columns as needed.
  • For each vehicle, if no data exists, a message and link will appear to redirect to the proper calculator

All summary pages:

  • All data is sorted recent to oldest, top to bottom.

Let me know if you find problems!

You need to run npm i to get the package I used for the circular progress indicators!

Closes tickets #26, #71

Copy link
Contributor

@TiciaD TiciaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing Ivan! The only issues I'm having is for mobile responsiveness. I don't know if you want to make a separate cleanup ticket for that or if you think they're easy fixes but here's what I've found:

Cards overlap on Tablet size screens (768px)
Screenshot 2022-09-08 181122

On mobile screens (320px) the cards are overflowing and getting cut off I think the padding for the cards needs to be smaller when on mobile
Screenshot 2022-09-08 181300

@ialej001
Copy link
Contributor Author

ialej001 commented Sep 8, 2022

Cards overlap on Tablet size screens (768px)

On mobile screens (320px) the cards are overflowing and getting cut off I think the padding for the cards needs to be smaller when on mobile

Fixed!

Copy link
Contributor

@TiciaD TiciaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those responsiveness issues! Looks good now, approved!

Copy link

@amandaalexandre amandaalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Are we production ready?

@ialej001 ialej001 merged commit f28eba1 into development Sep 10, 2022
@ialej001 ialej001 deleted the feature/ia-tickets-26-71-user-dashboard branch September 10, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants