Show an error message when Chrome tabs time out

christianrondeau · Sep 2, 2014 · 79b4a5f · 79b4a5f
1 parent 4b8b717
commit 79b4a5f
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 3 deletions.
diff --git a/GoToWindow.Extensibility/Controls/BasicListEntry.xaml b/GoToWindow.Extensibility/Controls/BasicListEntry.xaml
@@ -14,6 +14,7 @@
         </Grid.ColumnDefinitions>
         <Image Grid.Column="0" Source="{Binding Path=Icon}" Margin="8,8,8,8" />
         <TextBlock Grid.Column="1" HorizontalAlignment="Stretch" VerticalAlignment="Center" Margin="8,0,8,0" TextTrimming="CharacterEllipsis" Foreground="Gray" Text="{Binding Path=ProcessName}" />
-        <TextBlock  Grid.Column="2" HorizontalAlignment="Stretch" VerticalAlignment="Center" Margin="8,0,8,0" TextTrimming="CharacterEllipsis" Text="{Binding Path=Title}" />
+        <TextBlock Grid.Column="2" HorizontalAlignment="Stretch" VerticalAlignment="Center" Margin="8,0,8,0" TextTrimming="CharacterEllipsis" Text="{Binding Path=Title}" />
+		<TextBlock Grid.Column="2" HorizontalAlignment="Left" VerticalAlignment="Bottom" Margin="16,2,2,2" TextTrimming="CharacterEllipsis" Text="{Binding Path=Error}" Foreground="Red" FontSize="8" />
     </Grid>
 </UserControl>
diff --git a/GoToWindow.Extensibility/ViewModel/DesignTimeSearchResult.cs b/GoToWindow.Extensibility/ViewModel/DesignTimeSearchResult.cs
@@ -11,6 +11,7 @@ public class DesignTimeSearchResult : IBasicSearchResult
 		public BitmapFrame Icon { get; private set; }
 		public string Title { get; private set; }
 		public string ProcessName { get; private set; }
+		public string Error { get; set; }
 
 		public DesignTimeSearchResult()
 			: this(null, "process", "Window Title")

diff --git a/GoToWindow.Extensibility/ViewModel/IBasicSearchResult.cs b/GoToWindow.Extensibility/ViewModel/IBasicSearchResult.cs
@@ -7,5 +7,6 @@ public interface IBasicSearchResult : ISearchResult
 		BitmapFrame Icon { get; }
 		string Title { get; }
 		string ProcessName { get; }
+		string Error { get; }
 	}
 }
diff --git a/GoToWindow.Extensibility/ViewModel/IWindowSearchResult.cs b/GoToWindow.Extensibility/ViewModel/IWindowSearchResult.cs
@@ -2,8 +2,9 @@
 
 namespace GoToWindow.Extensibility.ViewModel
 {
-	public interface IWindowSearchResult : ISearchResult, IBasicSearchResult
+	public interface IWindowSearchResult : IBasicSearchResult
 	{
+		new string Error { get; set; }
 		IntPtr HWnd { get; }
 	}
 }
diff --git a/GoToWindow.Extensibility/ViewModel/SearchResultBase.cs b/GoToWindow.Extensibility/ViewModel/SearchResultBase.cs
@@ -5,6 +5,7 @@ namespace GoToWindow.Extensibility.ViewModel
 {
 	public abstract class SearchResultBase
 	{
+		public string Error { get; set; }
 		private readonly Func<UserControl> _viewCtor;
 	    private UserControl _view;
 

diff --git a/GoToWindow.Plugins.ExpandBrowsersTabs/ExpandBrowsersTabsPlugin.cs b/GoToWindow.Plugins.ExpandBrowsersTabs/ExpandBrowsersTabsPlugin.cs
@@ -67,6 +67,7 @@ public void BuildList(List<ISearchResult> list)
 
 				if (!task.Wait(TimeoutMilliseconds, token))
 				{
+					item.Error = "* Error: Timeout trying to get tabs";
 					Log.WarnFormat("Timeout trying to get tabs for '{0}'", browserName);
 					continue;
 				}

diff --git a/GoToWindow.Plugins.ExplorerExtensions/ViewModel/ExplorerWindowSearchResult.cs b/GoToWindow.Plugins.ExplorerExtensions/ViewModel/ExplorerWindowSearchResult.cs
@@ -14,6 +14,7 @@ public class ExplorerWindowSearchResult : IWindowSearchResult
 		public BitmapFrame Icon { get { return _window.Icon; } }
 		public string Title { get { return _path; } }
 		public string ProcessName { get { return _window.ProcessName; } }
+		public string Error { get { return _window.Error; } set { _window.Error = value; } }
 		public IntPtr HWnd { get { return _window.HWnd; } }
 
 		public bool IsShown(string searchQuery)

diff --git a/GoToWindow/ViewModels/DesignTimeMainViewModel.cs b/GoToWindow/ViewModels/DesignTimeMainViewModel.cs
@@ -23,7 +23,7 @@ public DesignTimeMainViewModel()
 				{
 					new DesignTimeSearchResult(icon, "process", "Window Title"),
 					new DesignTimeSearchResult(icon, "very long process name", "Very very long window title that should end up with ellipsis because it is so very long"),
-					new DesignTimeSearchResult(icon, "filler", "Some Window Title"),
+					new DesignTimeSearchResult(icon, "error", "This window has an error") { Error = "This is the error message" },
 					new DesignTimeSearchResult(icon, "filler", "Some Window Title"),
 					new DesignTimeSearchResult(icon, "filler", "Some Window Title"),
 					new DesignTimeSearchResult(icon, "filler", "Some Window Title"),