This repository has been archived by the owner on Oct 6, 2018. It is now read-only.
Fixes #36. Fixes #30. #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibanner56
changed the title
ibanner56
changed the title
|
Not all the client connections to kafka were being closed, only the one that was being used. Changed the client closing line (now line 80) to close all the clients that are being opened in getPartitionsLogSize. |
added 2 commits
December 9, 2014 16:00
ibanner56
changed the title
added 7 commits
December 16, 2014 16:46
ibanner56
changed the title
|
Six months and no review from maintainer? Thanks Isaac, will be testing your fork shortly. |
Retiring project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been an issue with web-console-consumer-XXXX nodes not being deleted after you leave a topic's page. I changed how the function was calling delete on the nodes so that it doesn't trigger an eventThread shutdown prior to the delete completing on the parent node. Now you don't end up with undeleted nodes in zookeeper.