Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/kcaching module vars #561

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Issues/kcaching module vars #561

wants to merge 9 commits into from

Conversation

remodietlicher
Copy link
Collaborator

Status

REVIEW

Description

Allows kcaching variables that are defined outside of the current function call.

Related issues

Issue #553

clementval
clementval reviewed Aug 19, 2019
View reviewed changes
Copy link
Collaborator

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna update the example for kcache because as you have found out they have a little flow. So I just put this on hold until the updated example are in and we can double check your new example makes sense as well.

@clementval clementval added this to the 2.0.1 milestone Aug 27, 2019
@clementval clementval modified the milestones: 2.0.1, 2.1 Sep 24, 2019
@clementval
Copy link
Collaborator

@remodietlicher Sorry I kept your PR waiting so long. I might work on CLAW in the next few weeks so it will be done at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clementval clementval clementval left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement translator
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@remodietlicher @clementval