Add about section #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 46.53% 44.92% -1.62%
==========================================
Files 21 21
Lines 1053 1113 +60
Branches 49 49
==========================================
+ Hits 490 500 +10
- Misses 514 564 +50
Partials 49 49
Continue to review full report at Codecov.
|
|
Hey, this is a great start, nice 💚 ! Some more things you can mention in the about text
You'll have to figure out where is a good place to link to the about page. Maybe in the footer, or maybe we can add a header. This would be a good opportunity to have a better look at some of the CSS.
|
|
you mentioned in a comment, that at some point you'd prefer to delete legacy.css and style.css and do the styling over in clean Garden+Tachyons. |
| (let [{:keys [chan-day-cnt chan-name->id] :as index} | ||
| (if (seq @!indexes) | ||
| @!indexes | ||
| {:chan-day-cnt {} :chan-name->id {}})] |
There was a problem hiding this comment.
This is a hack to solve #61. I'd like to find a clean solution. But the suggested (defonce !indexes (atom {:chan-name->id {} ,,,})) does not work, because after calling (go) at the repl, !indexes is reset to empty map {}. Question: which code is actually called when I type (go) at the repl?
There was a problem hiding this comment.
!indexes is already dereferenced on line 84, so instead of @!indexes just use indexes. I should have done that too on line 85. But this doesn't seem like the right solution, the when-let means that this function may return nil if there are no indexes, so the consumer should be able to work with that.
There was a problem hiding this comment.
(go) calls (user/go), which calls (reloaded.repl/go). This initializes the system (see user.clj:15) and starts it, so it starts all the components you see clojurians-log.application/prod-system + garden-watcher.
I would approach this differently, and make sure the indexes are nil when they are not built yet, or are built but there is no data. so change clojurians-log.db.queries so that (def !indexes (atom nil)), and on line 26 in the reduce replace the empty map with nil. This is fine because (assoc-in nil [...] ...) will return a map. This means channel-days will just work, either it returns a value, or nil. Then it's a matter of making sure the views work with that. Having a quick look I think we need an (if channel-days ...) branch in log-page-header
| :clojurians-log.routes/channel | ||
| {:channel name})} | ||
| "# " name]])] | ||
| [:p "no data loaded"])]]]) |
There was a problem hiding this comment.
Fix for #61. Question: is there a more suitable text than "no data loaded", especially for the production environment?
| (comment | ||
| (go) | ||
| (reset) | ||
| (reset-all) | ||
| (use 'clojurians-log.repl) | ||
| (load-demo-data! "../clojurians-log-demo-data") | ||
| #_:end) |
There was a problem hiding this comment.
Useful snippets for repl-driven development in Sapcemacs. Question: is there a better place to put this? Or do you bind those to some keystrokes in your IDE? Or in general: which keystrokes do you bind to which commands for repl-driven development?
There was a problem hiding this comment.
It's fine to have it in a comment here. Alternatively you can put it in a file in the repl/ directory.
I also use Spacemacs, with standard bindings like , e e to eval. I also have some leader key bindings myself.
(defun plexus-clojure-extras/cider-pprint-register (register)
(interactive (list (register-read-with-preview "Eval register: ")))
(cider--pprint-eval-form (get-register register)))
(dolist (m '(clojure-mode
clojurec-mode
clojurescript-mode
clojurex-mode
cider-repl-mode
cider-clojure-interaction-mode))
(spacemacs/set-leader-keys-for-major-mode m
"ep" 'cider-pprint-eval-last-sexp
"eP" 'cider-pprint-eval-last-sexp-to-comment
"en" 'cider-eval-ns-form
"er" 'cider-eval-last-sexp-and-replace
"," 'plexus-clojure-extras/cider-pprint-register
"lp" 'sesman-link-with-project
"lb" 'sesman-link-with-buffer
"lb" 'sesman-link-with-directory
"ll" 'sesman-link-with-least-specific
"ss" (if (eq m 'cider-repl-mode)
'cider-switch-to-last-clojure-buffer
'cider-switch-to-repl-buffer)
"'" 'cider-jack-in-clj
"\"" 'cider-jack-in-cljs
"\&" 'cider-jack-in-clj&cljs
"sq" 'cider-quit
))
I use , e p a lot. , e P will insert the result in the buffer in a comment, or you can use SPC u , e e to insert directly.
The bottom ones are to undo the recent keybinding changes in the spacemacs clojure layer.
I also have a special , , <register> binding, so I can put snippets in a register and eval them from anywhere. I don't use it a lot, but sometimes it's very handy.
| [:ul | ||
| (for [[{:channel/keys [name]} channel-days] channel-day-tuples] | ||
| (for [[day cnt] channel-days] | ||
| [:li [:a {:href (path-for context | ||
| :clojurians-log.routes/channel-date | ||
| {:channel name | ||
| :date day})} | ||
| "# " name " " day " (" cnt ")"]]))] |
|
Hey @kloimhardt, nice work! 🤩 Seems you are trying to tackle multiple issues at once here. Would you mind splitting that up into separate pull requests, one for each issue? It is not clear to me which of these three issues you're tackling is ready to be merged, and which are still in progress. It's also harder to evaluate and discuss them when they are mixed together like this.
That was really just a suggestion reflecting my own preferences at the time. What to do with that is largely up to whoever decides to do something about that, what their level of CSS and personal preferences are, and how much time they want to put in. We could make incremental improvements upon what we have, or start from scratch, in plain CSS, or with some framework, or using Garden... I personally still like Garden, but people who really do a lot of frontend seem to prefer things like plain CSS or SCSS. I think Tachyons is great if you're good at it as it allows very rapid prototyping. (I don't use it enough to properly remember the classes, and then it's less effective.) Recently I've used Tailwind CSS on a project, which seems to be a better Tachyons. So it's really up to you. This project is what people make of it. I'm just the guardian providing some guidance and historical background 😄 |
|
Thank you for all the valuable information. After doing some research on SCSS/Tachyons/Tailwind, I will stick to Garden because it seems the go-to option for a Clojure project when not having some already formed CSS preference :-). I will leave this master->master pull request as it is and start with very small ones again. Here, I was more following point 4 of the Clojure Etiquette "I am trying to make something and am having trouble, please help" and not point 1 "I made something - here is my contribution". Sorry for creating the confusion. Eventually we should get rid of this master->master pull request without merging anything from it. |
|
Alright! looking forward to the individual PRs! Let me know if you like any more help or input from me. |
|
Closing this as we are not planning to merge it. The things we want to keep can be brought up in separate PRs. |
This pull request addresses issue #63. It is meant to start things going, as there are some open points: