change !indexes from {} to nil #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexus
reviewed
Mar 17, 2020
| (reset-all) | ||
| (use 'clojurians-log.repl) | ||
| (load-demo-data! "../clojurians-log-demo-data") | ||
| #_:end) |
There was a problem hiding this comment.
Should I remove this admittedly confusing #:end)?
In my defence: Moving the closing bracket to the next line makes evaluating of the (load-demo-data ...) much easier, as I just move to eol with $ before before pressing ,ee. The #:end is just so that the bracket is not alone, sorry for having to bear with my sentimentality :-), should have cleaned this before committing, right?
There was a problem hiding this comment.
I took it out. It's not problematic as such, but it might confuse people.
There was a problem hiding this comment.
Thank you for this elegant solution.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #61 and adds some useful repl commands to user.clj . Concerning the comment "I think we need an (if channel-days ...) branch in log-page-header": I did not find a case where such an (if ...) was necessary, there were always the "Oops! No messages here!" and no 500 error.