This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Improve parsing of MIME parameter part #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem where single encoded + unencoded MIME parameter of same name get concatenated.
jkemp101
reviewed
Nov 1, 2019
There was a problem hiding this comment.
This lgtm but should we delete this fork and re-fork directly from https://github.com/mailgun/flanker? Might make it easier to get this merged upstream after we run it for a bit.
| @@ -107,8 +107,11 @@ def concatenate(parts): | |||
| if is_old_style(part): | |||
| # old-style parameters do not support any continuations | |||
| return encodedword.mime_to_unicode(get_value(part)) | |||
|
|
|||
| return ''.join(decode_new_style(p) for p in partition(parts)) | |||
| elif is_single_part(part): | |||
There was a problem hiding this comment.
I had to noodle through all of this for a bit to understand what it was now doing. We should probably enhance the docstring for this function that includes these two new formats it now supports.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like mailgun#103, but also prevents concatenating splitted and unsplitted params.