-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the support of Linux bridge interface for VM setup #158
Conversation
@jtaleric @rsevilla87 this change has been tested on 4.17 and 4.18 and is stable, it is ready for review. |
@capolrik hey! Lets get a rebase for this patchset and try to close out so we can begin adding this to our CPT pipelines. |
Use the --bridge option to create a NAD that will be attached to the VMs
ed33937
to
aaff0c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
VMHost string | ||
Udn bool | ||
Bridge bool | ||
BridgeServerNetwork string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BridgeServerAddress
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer Network, as it include the subnet mask, like '10.10.10.12/24'
… for bridge setup by passing a JSON file
/lgtm |
Use the --bridge option to create a NAD that will be attached to the VMs
Type of change
Description
Adding the support for bridge interface using VMs.
A NNCP needs to be defined before running the test to defined the linux bridge.
Then, the bridge name should be passed to the option:
with the following NNCP (nmstate operator required)
Related Tickets & Documents
Checklist before requesting a review
Testing
On OCP 4.17, 4.18.0.rc
and