Label hint #161
Merged
Label hint #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user wants to provide hints to help schedule the client and server on specific nodes, they can add `netperf=true` label to the nodes they want tested. Signed-off-by: Joe Talerico aka rook <[email protected]>
|
One improvement I thought was to hint to where to put the client and server... so the are basically are pinned to specific nodes... so |
This is a good idea. Making this provisioning more predictable makes the monitoring and the debugging setup easier. |
Allow the user to pick the server and client hosts individually. Signed-off-by: Joe Talerico aka rook <[email protected]>
|
Updated. Tested! Good to go! @capolrik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
If the user wants to provide hints to help schedule the client and server on specific nodes, they can add
netperf=truelabel to the nodes they want tested.Related Tickets & Documents
Checklist before requesting a review
Testing