passthrough: hornor no_open in do_getattr()

Otherwise we'll get EBADF failure as we can't find handle in handle map. Fixes: 2895435 ("passthrough: optimize async_do_getattr/do_getattr()") Signed-off-by: Eryu Guan <[email protected]>
cloud-hypervisor · Apr 27, 2022 · 98dbac7 · 98dbac7
1 parent e7fa805
commit 98dbac7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/passthrough/async_io.rs b/src/passthrough/async_io.rs
@@ -221,8 +221,11 @@ impl<D: AsyncDrive> PassthroughFs<D> {
             e
         })?;
 
-        if let Some(h) = handle {
-            let hd = self.handle_map.get(h, inode)?;
+        // kernel sends 0 as handle in case of no_open, and it depends on fuse server to handle
+        // this case correctly.
+        if !self.no_open.load(Ordering::Relaxed) && handle.is_some() {
+            // Safe as we just checked handle
+            let hd = self.handle_map.get(handle.unwrap(), inode)?;
             fd = hd.get_handle_raw_fd();
             st = self.async_stat_fd(ctx, fd, None).await;
         } else {

diff --git a/src/passthrough/sync_io.rs b/src/passthrough/sync_io.rs
@@ -222,8 +222,11 @@ impl<D: AsyncDrive> PassthroughFs<D> {
             e
         })?;
 
-        if let Some(h) = handle {
-            let hd = self.handle_map.get(h, inode)?;
+        // kernel sends 0 as handle in case of no_open, and it depends on fuse server to handle
+        // this case correctly.
+        if !self.no_open.load(Ordering::Relaxed) && handle.is_some() {
+            // Safe as we just checked handle
+            let hd = self.handle_map.get(handle.unwrap(), inode)?;
             fd = hd.get_handle_raw_fd();
             st = Self::stat_fd(fd, None);
         } else {