build: Split x86_64 specific code #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces `arch` mod for architecture specific code, and moves x86_64 related code under arch/x86_64. This change is to support multiple architecture. Signed-off-by: Akira Moroo <[email protected]>
retrage
force-pushed
the
split-x86_64-features
branch
2 times, most recently
from
aef4da3 to
714fd92
Compare
michael2012z
approved these changes
Oct 29, 2022
This commit merges `rust64_start()` for coreboot and pvh so that the entry function is implemented for each architecture. This commit includes suggested changes in [1]. [1] cloud-hypervisor#203 (comment) Signed-off-by: Akira Moroo <[email protected]>
Signed-off-by: Akira Moroo <[email protected]>
THis commit adds annotations for x86_64 specific code to prepare for supporting multiple architectures. NOTE: pci is marked as x86_64 specific code at the moment. This limitation will be removed later. Signed-off-by: Akira Moroo <[email protected]>
This change is to prepare for multiple architecture support. Signed-off-by: Akira Moroo <[email protected]>
This commit introduces `rdtsc()` and `pause()` to abstract architecture-specific instruction calls. Signed-off-by: Akira Moroo <[email protected]>
retrage
force-pushed
the
split-x86_64-features
branch
from
714fd92 to
46af1e7
Compare
retrage
added a commit
to retrage/rust-hypervisor-firmware
that referenced
this pull request
Oct 30, 2022
This commit merges `rust64_start()` for coreboot and pvh so that the entry function is implemented for each architecture. This commit includes suggested changes in [1]. [1] cloud-hypervisor#203 (comment) Signed-off-by: Akira Moroo <[email protected]>
rbradford
approved these changes
Oct 30, 2022
retrage
added a commit
that referenced
this pull request
Oct 31, 2022
This commit merges `rust64_start()` for coreboot and pvh so that the entry function is implemented for each architecture. This commit includes suggested changes in [1]. [1] #203 (comment) Signed-off-by: Akira Moroo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes splitting x86_64 specific code from architecture independent code. These changes are required for upcoming aarch64 support tracked in issue #198.