Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker images fixes in sanity #7

Closed
wants to merge 5 commits into from
Closed

fix: docker images fixes in sanity #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ca2ec1
Update Dockerfile
VishwajitNagulkar Sep 3, 2024
e6d585a
Update Dockerfile
VishwajitNagulkar Sep 3, 2024
6f96749
test
VishwajitNagulkar Sep 3, 2024
55f007d
test
VishwajitNagulkar Sep 3, 2024
20be64a
Merge branch 'fix/workflows' into test
VishwajitNagulkar Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@
FROM phusion/baseimage:jammy-1.0.4

#####################################
ENV LANG C.UTF-8

Check warning on line 5 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV LC_ALL en_US.UTF-8

Check warning on line 6 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV DEBIAN_FRONTEND noninteractive

###
ENV PHP_VERSION 8.3.10
ENV PACKER_VERSION 1.11.2

Check warning on line 11 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV TERRAFORM_VERSION 1.9.0

Check warning on line 12 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV ANSIBLE_VERSION 10.3.0

Check warning on line 13 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV LINT_VERSION 4.1.0
ENV KUBECTL_VERSION 1.31.0

Check warning on line 15 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV HELM_VERSION 3.15.1
ENV AZURE_CLI_VERSION 2.63.0-1~jammy
ENV AWS_CLI_VERSION 2.17.33

Check warning on line 18 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV K9s_Version 0.32.5
ENV GCLOUD_VERSION 489.0.0
ENV KUI_Version 13.1.4
ENV KUBECTX_VERSION 0.9.4

Check warning on line 22 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV KUBENS_VERSION 0.9.4

####################################
Expand All @@ -39,7 +39,7 @@
RUN chown -R ubuntu:ubuntu /home/ubuntu
RUN chmod 755 /home/ubuntu
ENV BOOT2DOCKER_ID 501
ENV BOOT2DOCKER_GID 20

Check warning on line 42 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
# Tweaks to give write permissions to the app
RUN usermod -u ${BOOT2DOCKER_ID} ubuntu && \
usermod -G staff ubuntu
Expand Down Expand Up @@ -76,8 +76,8 @@


# ZSH
ADD ./etc/install-zsh.sh /root/install-zsh.sh
ADD ./etc/install-zsh.sh /home/ubuntu/install-zsh.sh
ADD .docker/etc/install-zsh.sh /root/install-zsh.sh
ADD .docker/etc/install-zsh.sh /home/ubuntu/install-zsh.sh

RUN chmod +x /root/install-zsh.sh
RUN chmod +x /home/ubuntu/install-zsh.sh
Expand Down Expand Up @@ -144,7 +144,7 @@
mv google-cloud-sdk /usr/local/gcloud && \
/usr/local/gcloud/install.sh --quiet && \
rm /tmp/google-cloud-cli-${GCLOUD_VERSION}-linux-arm.tar.gz
ENV PATH $PATH:/usr/local/gcloud/google-cloud-sdk/bin

Check warning on line 147 in .docker/Dockerfile

View workflow job for this annotation

GitHub Actions / docker-scanner / Build Images

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

#k9s
RUN curl -LO https://github.com/derailed/k9s/releases/latest/download/k9s_Linux_amd64.tar.gz && \
Expand Down Expand Up @@ -183,4 +183,4 @@

# Define default command.
EXPOSE 22
CMD ["/usr/sbin/sshd", "-D"]
CMD ["/usr/sbin/sshd", "-D"]
4 changes: 2 additions & 2 deletions .github/workflows/sanity-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
uses: docker/[email protected]

- name: Build the application image
run: docker build -t clouddrove/devops:0.0.${{ github.run_number }} ./.docker/.

run: docker build -t clouddrove/devops:0.0.${{ github.run_number }} -f .docker/Dockerfile .
- name: Bring container up and running
run: docker run --name devops -d clouddrove/devops:0.0.${{ github.run_number }}

Expand Down
Loading