Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 🐛 Remove whole tags from public and private subnets #64

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix: 🐛 Remove whole tags from public and private subnets #64

merged 1 commit into from
Nov 30, 2023

Conversation

nileshgadgi
Copy link
Contributor

what

  • Removed tags from ignore changes in public and private subnets.

why

  • was not able to updated the current tags after deployment due to tags added in the lifecycle ignore changes.

@nileshgadgi nileshgadgi added the bug Something isn't working label Nov 30, 2023
@nileshgadgi nileshgadgi self-assigned this Nov 30, 2023
@nileshgadgi nileshgadgi requested a review from a team November 30, 2023 14:20
d4kverma
d4kverma approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themaniskshah themaniskshah merged commit 5795c98 into master Nov 30, 2023
24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/tags branch November 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4kverma d4kverma d4kverma approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nileshgadgi @themaniskshah @d4kverma @anmolnagpal