remove commented attributes

clouddrove · Dec 4, 2024 · 7f5980b · 7f5980b
1 parent e697b6c
commit 7f5980b
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 14 deletions.
diff --git a/examples/aks_with_microsoft_entra_id/example.tf b/examples/aks_with_microsoft_entra_id/example.tf
@@ -1,13 +1,14 @@
 provider "azurerm" {
   features {}
+  subscription_id = "000001-11111-1223-XXX-XXXXXXXXXXXX"
 }
 data "azurerm_client_config" "current_client_config" {}
 
 module "resource_group" {
   source  = "clouddrove/resource-group/azure"
   version = "1.0.2"
 
-  name        = "Public-app"
+  name        = "app-aks"
   environment = "test"
   label_order = ["name", "environment", ]
   location    = "Canada Central"
@@ -52,7 +53,7 @@ module "subnet" {
 
 module "log-analytics" {
   source                           = "clouddrove/log-analytics/azure"
-  version                          = "1.0.1"
+  version                          = "2.0.0"
   name                             = "app"
   environment                      = "test"
   label_order                      = ["name", "environment"]
@@ -63,9 +64,13 @@ module "log-analytics" {
 }
 
 module "vault" {
+  providers = {
+    azurerm.dns_sub  = azurerm, #chagnge this to other alias if dns hosted in other subscription.
+    azurerm.main_sub = azurerm
+  }
   source  = "clouddrove/key-vault/azure"
-  version = "1.1.0"
-  name    = "apptestwvshaks"
+  version = "1.2.0"
+  name    = "appakstestcd222"
   #environment         = local.environment
   resource_group_name = module.resource_group.resource_group_name
   location            = module.resource_group.resource_group_location
@@ -97,7 +102,7 @@ module "aks" {
   resource_group_name = module.resource_group.resource_group_name
   location            = module.resource_group.resource_group_location
 
-  kubernetes_version      = "1.27.7"
+  kubernetes_version      = "1.30.5"
   private_cluster_enabled = false
   default_node_pool = {
     name                  = "agentpool1"

diff --git a/examples/aks_with_microsoft_entra_id/versions.tf b/examples/aks_with_microsoft_entra_id/versions.tf
@@ -7,7 +7,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.112.0"
+      version = ">=3.112.0"
     }
   }
 }
diff --git a/examples/basic/example.tf b/examples/basic/example.tf
@@ -1,5 +1,6 @@
 provider "azurerm" {
   features {}
+  subscription_id = "000001-11111-1223-XXX-XXXXXXXXXXXX"
 }
 
 module "aks" {

diff --git a/examples/basic/versions.tf b/examples/basic/versions.tf
@@ -7,7 +7,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.112.0"
+      version = ">=3.112.0"
     }
   }
-}
+}
diff --git a/examples/complete/example.tf b/examples/complete/example.tf
@@ -1,6 +1,6 @@
 provider "azurerm" {
   features {}
-  subscription_id = "2334-12-343-23-##-34343"
+  subscription_id = "000001-11111-1223-XXX-XXXXXXXXXXXX"
 }
 data "azurerm_client_config" "current_client_config" {}
 

diff --git a/main.tf b/main.tf
@@ -255,8 +255,6 @@ resource "azurerm_kubernetes_cluster" "aks" {
 
     content {
       authorized_ip_ranges = var.api_server_access_profile.authorized_ip_ranges
-      # vnet_integration_enabled = var.api_server_access_profile.vnet_integration_enabled
-      # subnet_id                = var.api_server_access_profile.subnet_id
     }
   }
 
@@ -401,9 +399,8 @@ resource "azurerm_kubernetes_cluster" "aks" {
     for_each = var.storage_profile_enabled ? ["storage_profile"] : []
 
     content {
-      blob_driver_enabled = var.storage_profile.blob_driver_enabled
-      disk_driver_enabled = var.storage_profile.disk_driver_enabled
-      # disk_driver_version         = var.storage_profile.disk_driver_version
+      blob_driver_enabled         = var.storage_profile.blob_driver_enabled
+      disk_driver_enabled         = var.storage_profile.disk_driver_enabled
       file_driver_enabled         = var.storage_profile.file_driver_enabled
       snapshot_controller_enabled = var.storage_profile.snapshot_controller_enabled
     }