Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .deepsource.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = 1

[[analyzers]]
name = "terraform"
name = "terraform"
2 changes: 1 addition & 1 deletion .github/workflows/readme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ jobs:
uses: clouddrove/github-shared-workflows/.github/workflows/readme.yml@master
secrets:
TOKEN : ${{ secrets.GITHUB }}
SLACK_WEBHOOK_TERRAFORM: ${{ secrets.SLACK_WEBHOOK_TERRAFORM }}
SLACK_WEBHOOK_TERRAFORM: ${{ secrets.SLACK_WEBHOOK_TERRAFORM }}
4 changes: 2 additions & 2 deletions .github/workflows/tf-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
complete-example:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected]
with:
working_directory: './examples/complete/'
working_directory: './examples/complete/'
private_cluster-example:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected]
with:
Expand All @@ -24,4 +24,4 @@ jobs:
aks_with_microsoft_entra_id-example:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected]
with:
working_directory: './examples/aks_with_microsoft_entra_id/'
working_directory: './examples/aks_with_microsoft_entra_id/'
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
repos:

- repo: https://github.com/gruntwork-io/pre-commit
rev: v0.1.12 # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
rev: v0.1.23 # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
hooks:
- id: terraform-fmt
- id: shellcheck
- id: tflint

- repo: git://github.com/pre-commit/pre-commit-hooks
rev: v4.0.1 # Use the ref you want to point at
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0 # Use the ref you want to point at
hooks:
- id: end-of-file-fixer
- id: trailing-whitespace
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

[1.0.1]: https://github.com/clouddrove/terraform-azure-aks/compare/1.0.1...master

[1.0.2]: https://github.com/clouddrove/terraform-azure-aks/compare/1.0.1...1.0.2
[1.0.2]: https://github.com/clouddrove/terraform-azure-aks/compare/1.0.1...1.0.2
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<hr>


We are a group of DevOps engineers & architects, joining hands in this ever evolving digital landscape. With our strong belief in Automation; just like microservices, always on the lookout to split the the infrastructure into smaller connected resources (database, cluster and more) which could be standardized, are manageable, scalable, secure & follow industry best practices.
We are a group of DevOps engineers & architects, joining hands in this ever evolving digital landscape. With our strong belief in Automation; just like microservices, always on the lookout to split the the infrastructure into smaller connected resources (database, cluster and more) which could be standardized, are manageable, scalable, secure & follow industry best practices.


This module includes Terraform open source, examples, and automation tests (for better understanding), which would help you create and improve your infrastructure with minimalistic coding.
Expand All @@ -64,7 +64,7 @@ This module includes Terraform open source, examples, and automation tests (for
Refer to complete documentation: [here](docs/io.md)


<!--
<!--
## Module Dependencies

This module has dependencies on:
Expand All @@ -87,7 +87,7 @@ Refer [here](CHANGELOG.md).

## ✨ Contributors

Big thanks to our contributors for elevating our project with their dedication and expertise! But, we do not wish to stop there, would like to invite contributions from the community in improving these projects and making them more versatile for better reach. Remember, every bit of contribution is immensely valuable, as, together, we are moving in only 1 direction, i.e. forward.
Big thanks to our contributors for elevating our project with their dedication and expertise! But, we do not wish to stop there, would like to invite contributions from the community in improving these projects and making them more versatile for better reach. Remember, every bit of contribution is immensely valuable, as, together, we are moving in only 1 direction, i.e. forward.

<a href="https://github.com/clouddrove/terraform-azure-aks/graphs/contributors">
<img src="https://contrib.rocks/image?repo=clouddrove/terraform-azure-aks&max" />
Expand Down Expand Up @@ -115,7 +115,7 @@ Big thanks to our contributors for elevating our project with their dedication a



## Feedback
## Feedback
Spot a bug or have thoughts to share with us? Let's squash it together! Log it in our [issue tracker](https://github.com/clouddrove/terraform-azure-aks/issues), feel free to drop us an email at [[email protected]](mailto:[email protected]).

Show some love with a ★ on [our GitHub](https://github.com/clouddrove/terraform-azure-aks)! if our work has brightened your day! – your feedback fuels our journey!
Expand All @@ -127,7 +127,7 @@ We have [*100+ Terraform modules*][terraform_modules] 🙌. You could consider t

- [Terraform Module Registry:](https://registry.terraform.io/namespaces/clouddrove) Discover our Terraform modules here.

- [Terraform Modules for AWS/Azure Modules:](https://github.com/clouddrove/toc) Explore our comprehensive Table of Contents for easy navigation through our documentation for modules pertaining to AWS, Azure & GCP.
- [Terraform Modules for AWS/Azure Modules:](https://github.com/clouddrove/toc) Explore our comprehensive Table of Contents for easy navigation through our documentation for modules pertaining to AWS, Azure & GCP.

- [Terraform Modules for Digital Ocean:](https://github.com/terraform-do-modules/toc) Check out our specialized Terraform modules for Digital Ocean.

Expand All @@ -153,7 +153,7 @@ Join our tech elites [Join Now][slack] 🚀
Click [here][blog] :books: :star2:

## Tap into our capabilities
We provide a platform for organizations to engage with experienced top-tier DevOps & Cloud services. Tap into our pool of certified engineers and architects to elevate your DevOps and Cloud Solutions.
We provide a platform for organizations to engage with experienced top-tier DevOps & Cloud services. Tap into our pool of certified engineers and architects to elevate your DevOps and Cloud Solutions.

At [CloudDrove][website], has extensive experience in designing, building & migrating environments, securing, consulting, monitoring, optimizing, automating, and maintaining complex and large modern systems. With remarkable client footprints in American & European corridors, our certified architects & engineers are ready to serve you as per your requirements & schedule. Write to us at [[email protected]](mailto:[email protected]).

Expand Down
2 changes: 0 additions & 2 deletions README.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,5 +126,3 @@ usage: |-
log_analytics_workspace_id = module.log-analytics.workspace_id # when diagnostic_setting_enable = true && oms_agent_enabled = true
}
```


1 change: 0 additions & 1 deletion docs/io.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,3 @@
| kube\_config\_raw | Contains the Kubernetes config to be used by kubectl and other compatible tools. |
| name | Specifies the name of the AKS cluster. |
| node\_resource\_group | Specifies the resource id of the auto-generated Resource Group which contains the resources for this Managed Kubernetes Cluster. |

2 changes: 1 addition & 1 deletion examples/aks_with_microsoft_entra_id/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ module "aks" {
aks_user_auth_role = [{
scope = "/subscriptions/0**5e1cabc60c/resourceGroups/public-app-test-resource-group/providers/Microsoft.ContainerService/managedClusters/app1-test-aks1/namespaces/test"
role_definition_name = "Azure Kubernetes Service RBAC Admin"
principal_id = "***-**-***-**-***" # user or group object id
principal_id = "***-**-***-**-***" # user or group object id
}]

# acr_id = "****" #pass this value if you want aks to pull image from acr else remove it
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ module "aks" {
microsoft_defender_enabled = false
diagnostic_setting_enable = false
log_analytics_workspace_id = "/subscriptions/--------------<log_analytics_workspace_id>---------------"
}
}
2 changes: 1 addition & 1 deletion examples/basic/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ terraform {
version = "3.112.0"
}
}
}
}
6 changes: 3 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -912,11 +912,11 @@ resource "azurerm_monitor_diagnostic_setting" "aks-nic" {
}
}

## AKS user authentication with Azure Rbac.
## AKS user authentication with Azure Rbac.
resource "azurerm_role_assignment" "example" {
for_each = var.enabled && var.aks_user_auth_role != null ? { for k in var.aks_user_auth_role : k.principal_id => k } : null
# scope =
# scope =
scope = each.value.scope
role_definition_name = each.value.role_definition_name
principal_id = each.value.principal_id
}
}
1 change: 0 additions & 1 deletion outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ output "key_vault_secrets_provider" {
value = var.enabled && var.key_vault_secrets_provider_enabled ? azurerm_kubernetes_cluster.aks[0].key_vault_secrets_provider[0].secret_identity[0].object_id : null
description = "Specifies the obejct id of key vault secrets provider "
}

Loading