Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed Github Workflows and Added Major Changes to Module #5

Merged
merged 7 commits into from
Jan 9, 2025
Merged

fix: Fixed Github Workflows and Added Major Changes to Module #5

merged 7 commits into from
Jan 9, 2025

Conversation

vedant990
Copy link
Contributor

what

  • Fixed Github Workflows
  • Replaced Application id with Client Id
  • Updated and changed format of End-Time in example.tf as it was expired
  • Renamed Examples folder
  • Added Subscription_id

why

  • Application id is Depreciated
  • Subscription_id is Needed with Provider

@vedant990 vedant990 added the enhancement New feature or request label Oct 4, 2024
@vedant990 vedant990 requested review from 13archit and d4kverma October 4, 2024 11:17
@clouddrove-ci clouddrove-ci self-assigned this Oct 4, 2024
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  
  

  
      @vedant990
  vedant990


          requested a review
  from 13archit


    October 4, 2024 12:17    
    









      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  

  


        
        @d4kverma
  d4kverma



        merged commit 453e36c
      into

      
  
    master
  


    Jan 9, 2025

      

        10 checks passed
      


      

        
          
  
    
    

        
      

  
















  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


      

          

  
      @d4kverma
  
    d4kverma


                Awaiting requested review from d4kverma


        
      

      

          

  
      @13archit
  
    13archit


                Awaiting requested review from 13archit


        
      


      






    

  


      
  

    Assignees
  



        

      

        

  
      @clouddrove-ci
  
    clouddrove-ci
    

      








      


  


  

    Labels
  



    

      

    enhancement

  New feature or request








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      4 participants
    

    

        
          @vedant990 
        
          @clouddrove-ci 
        
          @13archit 
        
          @d4kverma