Upgrade prio 0.14.1 -> 0.15.3 and fix related taskprov issues #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
mendess
as code owners
cjpatton
commented
Oct 11, 2023
cjpatton
commented
Oct 11, 2023
cjpatton
force-pushed
the
cjpatton/dap07/2
branch
2 times, most recently
from
65f7909 to
c93d5ac
Compare
mendess
approved these changes
Oct 11, 2023
Merged
cjpatton
force-pushed
the
cjpatton/dap07/1
branch
from
c231ab8 to
44c7585
Compare
cjpatton
force-pushed
the
cjpatton/dap07/2
branch
from
c93d5ac to
1d048b1
Compare
Our taskprov implementation is meant to be compatible with DAP-02/VDAF-03. The latest version of the prio crate, 0.15.3, implements VDAF-07, so it's currently not operable. Remove support for the standardized VDAFs. Add support for Prio2 so that the protocol logic can still be tested.
cjpatton
force-pushed
the
cjpatton/dap07/2
branch
from
1d048b1 to
86ddd60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #400 (merge that first).
Partially addresses #350.
Partially addresses #386.
Our taskprov implementation is meant to be compatible with DAP-02/VDAF-03. The latest version of the prio crate, 0.15.3, implements VDAF-07, so it's currently not operable. Taskprov will need to catch up with DAP-07/VDAF-07. In the meantime, remove support for the old VDAFs. So that we can keep the testing logic intact, add support for Prio2, which hasn't change over the same time period.